Skip to content

V2 editor #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

V2 editor #77

wants to merge 4 commits into from

Conversation

SteelRazor47
Copy link

Hi, I saw you were open to PRs to implement the editor. Since I'm gonna need it in my project I thought I might take a stab at it.

So far I've added the add/delete/edit icons and what's needed to make the fields editable, but I haven't really touched the state management.
Before doing that I wanted to ask if you'd prefer to keep the v1 "style", where onEdit notifies a single change with a list of "namespace" keys, or if we could turn it into a more standard controlled react component where onEdit gives the whole updated json object. I'd prefer the latter since as a user having to update the object manually means a good amount of tedious boilerplate.

@SteelRazor47 SteelRazor47 marked this pull request as draft August 23, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant