Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I saw you were open to PRs to implement the editor. Since I'm gonna need it in my project I thought I might take a stab at it.
So far I've added the add/delete/edit icons and what's needed to make the fields editable, but I haven't really touched the state management.
Before doing that I wanted to ask if you'd prefer to keep the v1 "style", where onEdit notifies a single change with a list of "namespace" keys, or if we could turn it into a more standard controlled react component where onEdit gives the whole updated json object. I'd prefer the latter since as a user having to update the object manually means a good amount of tedious boilerplate.