Skip to content

fix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestions #11487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

fix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestions #11487

wants to merge 8 commits into from

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

Stacked on #11479

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 771f175
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/689f75a8e6266e000879f6a2
😎 Deploy Preview https://deploy-preview-11487--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 15, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 771f175

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 11s View ↗
nx run-many -t lint ✅ Succeeded 3m 29s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 16s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 4s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run integration-tests:test ✅ Succeeded 5s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-15 18:11:42 UTC

@codecov Codecov
Copy link

codecov bot commented Aug 15, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.88%. Comparing base (b2ee794) to head (771f175).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11487   +/-   ##
=======================================
  Coverage   90.87%   90.88%           
=======================================
  Files         505      505           
  Lines       51117    51112    -5     
  Branches     8415     8423    +8     
=======================================
- Hits        46455    46452    -3     
+ Misses       4648     4646    -2     
  Partials       14       14
Flag Coverage Δ
unittest 90.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts 98.36% <100.00%> (-0.03%) ⬇️
...es/eslint-plugin/src/util/getOperatorPrecedence.ts 62.17% <ø> (+0.74%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kirkwaiblinger kirkwaiblinger marked this pull request as ready for review August 15, 2025 18:59
@kirkwaiblinger kirkwaiblinger marked this pull request as draft August 15, 2025 18:59
@kirkwaiblinger kirkwaiblinger changed the title fix(eslint-plugin): [no-floating-promises] remove excessive parentheses in suggestions fix(eslint-plugin): [no-floating-promises] remove excess parentheses in suggestions Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-floating-promises] adds extra parentheses to already-parenthesized expression
1 participant
@kirkwaiblinger