Skip to content

Bug: [no-base-to-string] ignoredTypeNames should match on the type name without generics #11521

@tyilo

Description

@tyilo

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.9.2&fileType=.ts&code=JYOwLgpgTgZghgYwgAgLIE8CiUoHsoA8AKgHzIDeyAvgFA0AmECANnFCgriAM5jLR4oALjRYc%2BAiACuAWwBG0EgG4aA-ADowuAMpgooAOYAKAJRKgA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Jge1oCMBDZRLXxdk%2BKkwDm6MAG1w2HImjQO0SABp5CrAuyRKEztEQATAColEAOV4BbFNLm7dkALKEAostWQtugLp%2BEAC%2BfoEhIMFAA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

interface MyError<T> { }

declare const error: MyError<number>;
error.toString();

ESLint Config

{
  "rules": {
    "@typescript-eslint/no-base-to-string": [
      "error",
      {
        "ignoredTypeNames": [
          "MyError"
        ]
      }
    ]
  }
}

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

There should be no lints.

Actual Result

'error' will use Object's default stringification format ('[object Object]') when stringified. 4:1 - 4:6

Additional Info

I know you could add MyError<number> to the ignoredTypeNames, but that would only take care of a single possible generic type.

At runtime the generics don't exist, so whether toString() is overridden or not, can't depend on the generics. I think the ignoredTypeNames should be based on the type without generics.

There is some discussion in #11420

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugintriageWaiting for team members to take a look

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions