Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tokio-rs/tracing
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: tracing-attributes-0.1.30
Choose a base ref
...
head repository: tokio-rs/tracing
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 2 commits
  • 6 files changed
  • 2 contributors

Commits on Aug 15, 2025

  1. Fix CI (#3361) 

    * Implement PartialOrd for MatchPattern, MatchDebug in terms of Ord
* Fix missing link to supported regex syntax
* Update expected trybuild output
* Fix tracing_subscriber::Layer links
    @jplatte
    jplatte authored Aug 15, 2025
    Configuration menu
    Copy the full SHA
    3a1f571 View commit details
    Browse the repository at this point in the history

  2. subscriber: impl Clone for EnvFilter (#3360) 

    This is useful when using `EnvFilter` for multiple identical per-layer
filters, as well as with clap and similar libraries that have `Clone`
bounds.

We generally expect users to be cloning an `EnvFilter` before attaching it
to a subscriber, rather than cloning `EnvFilters` that are already
attached. Because of this, we reset all the accumulated dynamic state
when cloning. This means that some spans and callsites might be missed
when an already-attached `EnvFilter` is cloned, but the presence of the
dynamic state mean that detaching and attaching `EnvFilter`s to existing
subscribers (e.g. with `reload`) already doesn't work very well. This
isn't a new class of problem.

There was a previous implementation of this in #2398, that shared the
dynamic state between all cloned filters behind an `Arc`. I chose
not do go for that approach because it causes inconsistencies if the
cloned filters are attached to different subscribers.

Fixes: #2360
    @olivia-fl
    olivia-fl authored Aug 15, 2025
    Configuration menu
    Copy the full SHA
    f71cebe View commit details
    Browse the repository at this point in the history
Loading