Allow flat_hash_map to use move-only keys. #99271
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow flat_hash_map to use move-only keys.
I want to use flat_hash_map with a key type that's very expensive to copy.
To avoid accidental copies I want to make the copy ctor inaccessible,
and instead provide an explicit ExpensiveCopy() function that will make copies.
Something along the following lines:
class X {
X(const X&) = default;
public:
X(...);
X(X&&) = default;
X ExpensiveCopy() const { return *this; }
};
And then use it as follows:
flat_hash_map<X, bool> m;
m[x.ExpensiveCopy()] = ...;
Currently it does not compile, since hash map code still tries
to call the copy ctor on a non-executed path.
Use "if constexpr" to avoid calling the ctor.