Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/var-exporter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.4.20
Choose a base ref
...
head repository: symfony/var-exporter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.4.21
Choose a head ref
  • 4 commits
  • 5 files changed
  • 3 contributors

Commits on Apr 27, 2025

  1. Remove unneeded use statements

    @fabpot
    fabpot committed Apr 27, 2025
    Configuration menu
    Copy the full SHA
    4badc59 View commit details
    Browse the repository at this point in the history

  2. [VarExporter] Fix: Use correct closure call for property-specific log… 

    …ic in $notByRef
    @Hakayashii @fabpot
    Hakayashii authored and fabpot committed Apr 27, 2025
    Configuration menu
    Copy the full SHA
    f2b47e6 View commit details
    Browse the repository at this point in the history

  3. bug #60258 [VarExporter] Fix: Use correct closure call for property-s… 

    …pecific logic in $notByRef (Hakayashii, denjas)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[VarExporter] Fix: Use correct closure call for property-specific logic in $notByRef

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix #...
| License       | MIT

Previously, $notByRef was treated as a callable instead of an array of closures. Now, the closure is correctly invoked with $notByRef[$name]($object, $value) if it's not true.

Encountered the following error after loading an entity from the database using Doctrine, which held a reference to another entity. The error occurred when modifying this lazily-loaded reference.
```
[critical] Uncaught Error: Array callback must have exactly two elements

In Hydrator.php line 163:

  [Error]
  Array callback must have exactly two elements

Exception trace:
  at C:\Users\hakayashii\repos\test\vendor\symfony\var-exporter\Internal\Hydrator.php:163
 Proxies\__CG__\App\Entity\Subscription->{closure:Symfony\Component\VarExporter\Internal\Hydrator::getSimpleHydrator():155}() at C:\Users\hakayashii\repos\test\vendor\symfony\var-exporter\Hydrator.php:72
 Symfony\Component\VarExporter\Hydrator::hydrate() at C:\Users\hakayashii\repos\test\vendor\symfony\var-exporter\Internal\LazyObjectState.php:56
 Symfony\Component\VarExporter\Internal\LazyObjectState->initialize() at C:\Users\hakayashii\repos\test\vendor\symfony\var-exporter\LazyGhostTrait.php:146
 Proxies\__CG__\App\Entity\Subscription->__get() at C:\Users\hakayashii\repos\test\src\Service\OrderBuilder.php:45
[...]
```

Commits
-------

b1f06026179 [VarExporter] Fix: Use correct closure call for property-specific logic in $notByRef
    @fabpot
    fabpot committed Apr 27, 2025
    Configuration menu
    Copy the full SHA
    f0bc90a View commit details
    Browse the repository at this point in the history

  4. dump default value for property hooks if present

    @xabbuh
    xabbuh committed Apr 27, 2025
    Configuration menu
    Copy the full SHA
    717e754 View commit details
    Browse the repository at this point in the history
Loading