Fix failing notifier option tests

OskarStark · OskarStark · commit 7dff9a9128fe · 2025-08-24T13:01:00.000+02:00
- Fix Telegram InlineKeyboardButton import path and use inlineKeyboard() method
- Update LinkedIn test expectations to include attributes array and fix AuthorShare constructor
- Update RocketChat test expectations to match current empty array behavior
diff --git a/src/Symfony/Component/Notifier/Bridge/LinkedIn/Tests/LinkedInOptionsTest.php b/src/Symfony/Component/Notifier/Bridge/LinkedIn/Tests/LinkedInOptionsTest.php
@@ -38,7 +38,7 @@ public function testLinkedInOptions()
 
     public function testLinkedInOptionsWithAllMethods()
     {
-        $author = new AuthorShare('urn:li:person:123456');
+        $author = new AuthorShare('123456');
         $lifecycleState = new LifecycleStateShare('PUBLISHED');
         $visibility = new VisibilityShare();
         $specificContent = new ShareContentShare('Test content');
@@ -64,6 +64,7 @@ public function testLinkedInOptionsWithAllMethods()
             'specificContent' => [
                 'com.linkedin.ugc.ShareContent' => [
                     'shareCommentary' => [
+                        'attributes' => [],
                         'text' => 'Test content',
                     ],
                     'shareMediaCategory' => 'NONE',
@@ -90,6 +91,7 @@ public function testFromNotification()
             'specificContent' => [
                 'com.linkedin.ugc.ShareContent' => [
                     'shareCommentary' => [
+                        'attributes' => [],
                         'text' => 'Test Content',
                     ],
                     'shareMediaCategory' => 'NONE',
@@ -114,6 +116,7 @@ public function testFromNotificationWithoutContent()
             'specificContent' => [
                 'com.linkedin.ugc.ShareContent' => [
                     'shareCommentary' => [
+                        'attributes' => [],
                         'text' => 'Test Subject Only',
                     ],
                     'shareMediaCategory' => 'NONE',
diff --git a/src/Symfony/Component/Notifier/Bridge/RocketChat/Tests/RocketChatOptionsTest.php b/src/Symfony/Component/Notifier/Bridge/RocketChat/Tests/RocketChatOptionsTest.php
@@ -40,9 +40,7 @@ public function testRocketChatOptionsWithChannel()
         $options = (new RocketChatOptions())
             ->channel('#general');
 
-        $this->assertSame([
-            'attachments' => [[]],
-        ], $options->toArray());
+        $this->assertSame([], $options->toArray());
 
         $this->assertSame('#general', $options->getRecipientId());
     }
@@ -98,8 +96,6 @@ public function testEmptyAttachments()
     {
         $options = new RocketChatOptions();
 
-        $this->assertSame([
-            'attachments' => [[]],
-        ], $options->toArray());
+        $this->assertSame([], $options->toArray());
     }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramOptionsTest.php b/src/Symfony/Component/Notifier/Bridge/Telegram/Tests/TelegramOptionsTest.php
@@ -13,7 +13,7 @@
 
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
-use Symfony\Component\Notifier\Bridge\Telegram\Reply\Markup\InlineKeyboardButton;
+use Symfony\Component\Notifier\Bridge\Telegram\Reply\Markup\Button\InlineKeyboardButton;
 use Symfony\Component\Notifier\Bridge\Telegram\Reply\Markup\InlineKeyboardMarkup;
 use Symfony\Component\Notifier\Bridge\Telegram\TelegramOptions;
 
@@ -120,7 +120,7 @@ public function testWithReplyMarkup()
         $button2->callbackData('callback_2');
 
         $markup = new InlineKeyboardMarkup();
-        $markup->addRow([$button1, $button2]);
+        $markup->inlineKeyboard([$button1, $button2]);
 
         $options = (new TelegramOptions())
             ->chatId('123456')

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,7 @@ public function testRocketChatOptionsWithChannel()`
`40`	`40`	`$options = (new RocketChatOptions())`
`41`	`41`	`->channel('#general');`
`42`	`42`
`43`		`- $this->assertSame([`
`44`		`- 'attachments' => [[]],`
`45`		`- ], $options->toArray());`
	`43`	`+ $this->assertSame([], $options->toArray());`
`46`	`44`
`47`	`45`	`$this->assertSame('#general', $options->getRecipientId());`
`48`	`46`	`}`
`@@ -98,8 +96,6 @@ public function testEmptyAttachments()`
`98`	`96`	`{`
`99`	`97`	`$options = new RocketChatOptions();`
`100`	`98`
`101`		`- $this->assertSame([`
`102`		`- 'attachments' => [[]],`
`103`		`- ], $options->toArray());`
	`99`	`+ $this->assertSame([], $options->toArray());`
`104`	`100`	`}`
`105`	`101`	`}`