added check for TLS too short error

shadowy-pycoder · shadowy-pycoder · commit f468b2ec44f3 · 2025-07-06T09:47:51.000+03:00
diff --git a/layers/tls.go b/layers/tls.go
@@ -15,6 +15,8 @@ const (
 	ServerHelloTLSVal = 0x02
 )
 
+var TLSTooShortErr = fmt.Errorf("tls message too short")
+
 type TLSVersion struct {
 	Value uint16
 	Desc  string
@@ -117,7 +119,7 @@ type TLSClientHello struct {
 	TypeDesc           string
 	Length             int // 3 bytes int(uint(b[2]) | uint(b[1])<<8 | uint(b[0])<<16))
 	Version            *TLSVersion
-	Random             []byte //32 bytes
+	Random             []byte // 32 bytes
 	SessionIDLength    uint8  // if 0 no session follows
 	SessionID          string
 	CipherSuitesLength uint16
@@ -178,12 +180,12 @@ func (tch *TLSClientHello) String() string {
  - Random: %s
  - SessionIDLength: %d
  - SessionID: %s
- - CipherSuitesLength: %d 
+ - CipherSuitesLength: %d
  - CipherSuites: %v
  - CmprMethodsLength: %d
- - CmprMethods: %v 
+ - CmprMethods: %v
  - ExtensionLength: %d
- - Extensions: %v  
+ - Extensions: %v
  - %s
  - ALPN: %v
 `,
@@ -233,7 +235,7 @@ func (tch *TLSClientHello) ParseHS(data []byte) error {
 	}
 	csl := binary.BigEndian.Uint16(data[sid : sid+2]) // data[71:73] suites count * 2 bytes
 	tch.CipherSuitesLength = csl
-	offset := uint16(sid + 2)  //73
+	offset := uint16(sid + 2)  // 73
 	cmproffset := csl + offset // 107
 	css := make([]*CipherSuite, 0, csl/2)
 	var i uint16
@@ -285,8 +287,8 @@ func (tch *TLSClientHello) ParseHS(data []byte) error {
 				return err
 			}
 			tch.ServerName = sn
-		case 16: //ALPN
-			//skip data[i+4:i+6] alpn extension length
+		case 16: // ALPN
+			// skip data[i+4:i+6] alpn extension length
 			if len(data) < int(i+6) {
 				return nil
 			}
@@ -318,7 +320,7 @@ type TLSServerHello struct {
 	TypeDesc         string
 	Length           int // 3 bytes int(uint(b[2]) | uint(b[1])<<8 | uint(b[0])<<16))
 	Version          *TLSVersion
-	Random           []byte //32 bytes
+	Random           []byte // 32 bytes
 	SessionIDLength  uint8  // if 0 no session follows
 	SessionID        string
 	CipherSuite      *CipherSuite
@@ -374,10 +376,10 @@ func (tsh *TLSServerHello) String() string {
  - SessionIDLength: %d
  - SessionID: %s
  - CipherSuite: %s
- - CmprMethod: %d 
+ - CmprMethod: %d
  - ExtensionLength: %d
- - Extensions: %v  
- - Supported Version: %s 
+ - Extensions: %v
+ - Supported Version: %s
 `,
 		tsh.TypeDesc,
 		tsh.Type,
@@ -539,7 +541,7 @@ func (t *TLSMessage) printRecords() string {
 func (t *TLSMessage) Parse(data []byte) error {
 	t.Records = make([]*Record, 0, 5)
 	if len(data) < headerSizeTLS {
-		return nil
+		return TLSTooShortErr
 	}
 	for len(data) > 0 {
 		ctype := data[0]
@@ -1388,6 +1390,7 @@ func csuitedesc(csuite uint16) string {
 	}
 	return csuitedesc
 }
+
 func extdesc(ext uint16) string {
 	var extdesc string
 	switch ext {
diff --git a/mshark.go b/mshark.go
@@ -51,7 +51,8 @@ func NewWriter(w io.Writer, verbose bool) *Writer {
 	return &Writer{
 		w:       w,
 		stdout:  w == os.Stdout,
-		verbose: verbose}
+		verbose: verbose,
+	}
 }
 
 // printPacket prints a layer packet to the writer. If the writer is an instance of os.Stdout,
@@ -161,7 +162,6 @@ func InterfaceByName(name string) (*net.Interface, error) {
 // OpenLive opens a live capture based on the given configuration and writes
 // all captured packets to the given PacketWriters.
 func OpenLive(conf *Config, pw ...PacketWriter) error {
-
 	packetcfg := packet.Config{}
 
 	// setting up filter
@@ -237,7 +237,7 @@ func OpenLive(conf *Config, pw ...PacketWriter) error {
 			return fmt.Errorf("failed to read Ethernet frame: %v", err)
 		}
 		for _, w := range pw {
-			if err := w.WritePacket(time.Now().UTC(), b[:n]); err != nil {
+			if err := w.WritePacket(time.Now().UTC(), b[:n]); err != nil && !errors.Is(err, layers.TLSTooShortErr) {
 				return err
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,8 @@ func NewWriter(w io.Writer, verbose bool) *Writer {`
`51`	`51`	`return &Writer{`
`52`	`52`	`w: w,`
`53`	`53`	`stdout: w == os.Stdout,`
`54`		`- verbose: verbose}`
	`54`	`+ verbose: verbose,`
	`55`	`+ }`
`55`	`56`	`}`
`56`	`57`
`57`	`58`	`// printPacket prints a layer packet to the writer. If the writer is an instance of os.Stdout,`
`@@ -161,7 +162,6 @@ func InterfaceByName(name string) (*net.Interface, error) {`
`161`	`162`	`// OpenLive opens a live capture based on the given configuration and writes`
`162`	`163`	`// all captured packets to the given PacketWriters.`
`163`	`164`	`func OpenLive(conf *Config, pw ...PacketWriter) error {`
`164`		`-`
`165`	`165`	`packetcfg := packet.Config{}`
`166`	`166`
`167`	`167`	`// setting up filter`
`@@ -237,7 +237,7 @@ func OpenLive(conf *Config, pw ...PacketWriter) error {`
`237`	`237`	`return fmt.Errorf("failed to read Ethernet frame: %v", err)`
`238`	`238`	`}`
`239`	`239`	`for _, w := range pw {`
`240`		`- if err := w.WritePacket(time.Now().UTC(), b[:n]); err != nil {`
	`240`	`+ if err := w.WritePacket(time.Now().UTC(), b[:n]); err != nil && !errors.Is(err, layers.TLSTooShortErr) {`
`241`	`241`	`return err`
`242`	`242`	`}`
`243`	`243`	`}`