-
Notifications
You must be signed in to change notification settings - Fork 14
Comparing changes
Open a pull request
base repository: ruby/syntax_suggest
base: v2.0.1
head repository: ruby/syntax_suggest
compare: v2.0.2
- 12 commits
- 12 files changed
- 4 contributors
Commits on Oct 28, 2024
-
Bump actions/checkout from 4.2.1 to 4.2.2
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.2.1...v4.2.2) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Configuration menu - View commit details
-
Copy full SHA for c7c9626 - Browse repository at this point
Copy the full SHA c7c9626View commit details
Commits on Oct 29, 2024
-
Merge pull request #230 from ruby/dependabot/github_actions/actions/c…
…heckout-4.2.2 Bump actions/checkout from 4.2.1 to 4.2.2
Configuration menu - View commit details
-
Copy full SHA for f2a4fa3 - Browse repository at this point
Copy the full SHA f2a4fa3View commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e2b9744 - Browse repository at this point
Copy the full SHA e2b9744View commit details -
Merge pull request #231 from ruby/skip-changelog-dependabot
Added 'skip changelog' label for dependabot update
Configuration menu - View commit details
-
Copy full SHA for eb4f254 - Browse repository at this point
Copy the full SHA eb4f254View commit details
Commits on Nov 15, 2024
-
Fix missing line break due to puts logic
In #225 it was reported that the output looks incorrect: ``` $ cat /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb def x.y.z end $ ruby /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb: --> /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb expected a delimiter to close the parametersunexpected '.', ignoring it > 1 def x.y.z > 2 end ``` Specifically: ``` expected a delimiter to close the parametersunexpected '.', ignoring it ``` However this does not show up when executing the debug executable: ``` $ bin/bundle exec exe/syntax_suggest /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb --> /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb expected a delimiter to close the parameters unexpected '.', ignoring it > 1 def x.y.z > 2 end ``` This is because `exe/syntax_suggest` uses STDOUT.puts while calling `ruby` with the filename uses a fake IO object represented by MiniStringIO. This class was incorrectly not adding a newline to the end of the print. The fix was to move the class to it's own file where it can be tested and then fix the behavior. close #225 Co-authored-by: Andy Yong <andyywz@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d2ecd94 - Browse repository at this point
Copy the full SHA d2ecd94View commit details -
Merge pull request #232 from ruby/schneems/fix-run-on-sentence
Fix missing line break due to puts logic
Configuration menu - View commit details
-
Copy full SHA for bfb0f22 - Browse repository at this point
Copy the full SHA bfb0f22View commit details -
Configuration menu - View commit details
-
Copy full SHA for b17bf0b - Browse repository at this point
Copy the full SHA b17bf0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c78283 - Browse repository at this point
Copy the full SHA 9c78283View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c36b0c - Browse repository at this point
Copy the full SHA 8c36b0cView commit details -
Merge pull request #233 from ruby/schneems/nov-15
Update docs and comments
Configuration menu - View commit details
-
Copy full SHA for 1430e94 - Browse repository at this point
Copy the full SHA 1430e94View commit details -
Configuration menu - View commit details
-
Copy full SHA for e99b5ba - Browse repository at this point
Copy the full SHA e99b5baView commit details -
Configuration menu - View commit details
-
Copy full SHA for e6dc9ff - Browse repository at this point
Copy the full SHA e6dc9ffView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.0.1...v2.0.2