Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ruby/syntax_suggest
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.1
Choose a base ref
...
head repository: ruby/syntax_suggest
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.2
Choose a head ref
  • 12 commits
  • 12 files changed
  • 4 contributors

Commits on Oct 28, 2024

  1. Bump actions/checkout from 4.2.1 to 4.2.2

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.1 to 4.2.2.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v4.2.1...v4.2.2)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c7c9626 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Merge pull request #230 from ruby/dependabot/github_actions/actions/c…

    …heckout-4.2.2
    
    Bump actions/checkout from 4.2.1 to 4.2.2
    hsbt authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    f2a4fa3 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    e2b9744 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #231 from ruby/skip-changelog-dependabot

    Added 'skip changelog' label for dependabot update
    hsbt authored Oct 31, 2024
    Configuration menu
    Copy the full SHA
    eb4f254 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Fix missing line break due to puts logic

    In #225 it was reported that the output looks incorrect:
    
    ```
    $ cat /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb
    def x.y.z
    end
    $ ruby /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb
    /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb: --> /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb
    expected a delimiter to close the parametersunexpected '.', ignoring it
    > 1  def x.y.z
    > 2  end
    ```
    
    Specifically:
    
    ```
    expected a delimiter to close the parametersunexpected '.', ignoring it
    ```
    
    However this does not show up when executing the debug executable:
    
    ```
    $ bin/bundle exec exe/syntax_suggest /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb
    --> /tmp/4a71c7e417cc9eac0971e3a2519b295c/scratch.rb
    
    expected a delimiter to close the parameters
    unexpected '.', ignoring it
    
    > 1  def x.y.z
    > 2  end
    ```
    
    This is because `exe/syntax_suggest` uses STDOUT.puts while calling `ruby` with the filename uses a fake IO object represented by MiniStringIO. This class was incorrectly not adding a newline to the end of the print.
    
    The fix was to move the class to it's own file where it can be tested and then fix the behavior.
    
    close #225
    
    Co-authored-by: Andy Yong <andyywz@gmail.com>
    schneems and andyywz committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d2ecd94 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #232 from ruby/schneems/fix-run-on-sentence

    Fix missing line break due to puts logic
    schneems authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    bfb0f22 View commit details
    Browse the repository at this point in the history
  3. Freeze strings

    schneems committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    b17bf0b View commit details
    Browse the repository at this point in the history
  4. Fix spelling

    schneems committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9c78283 View commit details
    Browse the repository at this point in the history
  5. Explain why class exists

    schneems committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8c36b0c View commit details
    Browse the repository at this point in the history
  6. Merge pull request #233 from ruby/schneems/nov-15

    Update docs and comments
    schneems authored Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1430e94 View commit details
    Browse the repository at this point in the history
  7. v2.0.2

    schneems committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e99b5ba View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e6dc9ff View commit details
    Browse the repository at this point in the history
Loading