Before	After

We were emitting semantic tokens for identifiers that didn't actually appear in source code. For example, array spreads (...) are converted by the compiler to Belt.Array.concatMany and so SemanticTokens was emitting identifer tokens for this function.

This fix will prevent semantic highlighting of Array.get and Array.set (syntax highlighting will stil work) as we can't differentiate array[index] and array[index] = ... from Array.get/Array.set in the AST. This will be fixed in a follow up PR. (WIP branch)

Deferred work:

• Implement @res.arrayGet/@res.arraySet attributes so we don't skip generating semantic tokens for direct use of Array.get/Array.set (See Add attr res.array{Get,Set} to Array.{get, set} #6343)
  • WIP branch. Need to figure out what to do about existing handling of Array.get/set in res_printer.ml
• Backport .../Belt.Array.concatMany fix to rescript-vscode's SemanticTokens.ml