shared/src/constants/extension.ts (2)

1-9: Consider avoiding namespace + runtime enums in favor of module-level as const objects

Namespaces and string enums generate extra runtime artifacts and can be unfriendly with Babel/esbuild-only pipelines. A more bundler-friendly pattern is flat module exports using as const objects + derived union types. If this is consistent with the repo’s style, consider this refactor.

Apply this diff if you want to move to flat exports:

-export namespace ExtensionConstants {
-  export enum StorageKeys {
-    POPUP_CONFIG = "popup_config",
-  }
-
-  export enum ExtensionMessages {
-    OPEN_CURL_IMPORT_MODAL = "openCurlImportModal",
-  }
-}
+export const ExtensionStorageKeys = {
+  POPUP_CONFIG: "popup_config",
+} as const;
+export type ExtensionStorageKey = typeof ExtensionStorageKeys[keyof typeof ExtensionStorageKeys];
+
+export const ExtensionMessages = {
+  OPEN_CURL_IMPORT_MODAL: "openCurlImportModal",
+} as const;
+export type ExtensionMessage = typeof ExtensionMessages[keyof typeof ExtensionMessages];

Notes:

• Flat exports tree-shake well, avoid IIFEs generated for namespaces, and don’t rely on TS enum emit.
• If any call sites already expect ExtensionConstants.StorageKeys shape, keep the current approach. Otherwise, adopting flat exports now will simplify future usage.

---

2-4: StorageKeys and ExtensionMessages conventions verified; no raw strings to replace

• Storage key values use snake_case (e.g. "popup_config") as intended for persisted data.
• Message identifiers use camelCase (e.g. "openCurlImportModal"), matching existing definitions in
  common/constants.js and browser-extension/common/src/constants.ts.
• No occurrences of these raw string literals were found outside the enum definitions in
  shared/src/constants/extension.ts.
• If you’re adding new call sites, import and reference these enums instead of hard-coding strings.

Optional: OPEN_CURL_IMPORT_MODAL is currently defined in three places—consider consolidating into a single source of truth to prevent drift.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.