-
Notifications
You must be signed in to change notification settings - Fork 112
Migrate to Gtk4 #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Migrate to Gtk4 #360
Conversation
ff1ed3f
to
2b2d381
Compare
clients/nautilus/RabbitVCS.py
Outdated
import cProfile | ||
|
||
path = S(gnomevfs.get_local_path_from_uri(item.get_uri())).replace("/", ":") | ||
|
||
profile_data_file = os.path.join( | ||
helper.get_home_folder(), "checkerservice_%s.stats" % path | ||
) | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you are doing some pretty substantive work here, I've bumped you up to maintainer |
I just tried your gtk4 branch on GNOME 44 and it's working well with Nautilus. However, this PR can't be merged as it's not up to date with this repo. At some point you did not pull upstream before making changes. FYI, It does not work with Nemo. Maybe the other file manager plugins can be addressed later.
|
I will rebase the branch soon, there are no relevant commits on master yet. I'm currently focusing on nautilus and git dialogs. After that I will take a look into the other plugins and VCS. |
I love that tool and I have gnome 44. Thank you so much for your work porting that over to GTK4!!! 🙇 |
@philippun1 given the amount of work you've done, what do you think is left? Happy to start testing on this branch over the next few months if you like, with an eye towards merging it |
@CloCkWeRX All the dialogs are done, whats missing are the context menus. I tested all the git dialogs and most of the svn dialogs. But a second pair of eyes would certainly be helpful. Since the popover menus have completely changed with gtk4, they probably need to be rewritten. |
Dialogs use Adw.Dialog if available, otherwise they will fallback to regular Gtk.Dialog.
Dialog status:
Other:
Only tested with git and svn at the moment.