From 74fc55078530f3c78ad9e8f377db4b0c4de7a792 Mon Sep 17 00:00:00 2001 From: Erik Welch Date: Tue, 21 Feb 2023 19:37:56 +0100 Subject: [PATCH 1/2] Fix complex arcsin test on Windows --- .github/workflows/test_and_build.yml | 2 +- graphblas/tests/test_numpyops.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index ea82052f8..ef72bfcd5 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -121,7 +121,7 @@ jobs: 2 1 1 - 1 + 10000 - name: Setup conda uses: conda-incubator/setup-miniconda@v2 with: diff --git a/graphblas/tests/test_numpyops.py b/graphblas/tests/test_numpyops.py index fc24762bc..c528d4051 100644 --- a/graphblas/tests/test_numpyops.py +++ b/graphblas/tests/test_numpyops.py @@ -65,11 +65,11 @@ def test_npunary(): "INT64": {"reciprocal"}, "FC64": {"ceil", "floor", "trunc"}, } - if suitesparse and is_win: + if suitesparse and is_win and gb.config["mapnumpy"]: # asin and asinh are known to be wrong in SuiteSparse:GraphBLAS # due to limitation of MSVC with complex - blocklist["FC64"].update({"asin", "asinh"}) - blocklist["FC32"] = {"asin", "asinh"} + blocklist["FC64"].update({"arcsin", "arcsinh"}) + blocklist["FC32"] = {"arcsin", "arcsinh"} isclose = gb.binary.isclose(1e-6, 0) for gb_input, np_input in data: for unary_name in sorted(npunary._unary_names): From bc0f3cbf03023d603afeec28b10120e86f117256 Mon Sep 17 00:00:00 2001 From: Erik Welch Date: Tue, 21 Feb 2023 19:39:35 +0100 Subject: [PATCH 2/2] undo --- .github/workflows/test_and_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test_and_build.yml b/.github/workflows/test_and_build.yml index ef72bfcd5..ea82052f8 100644 --- a/.github/workflows/test_and_build.yml +++ b/.github/workflows/test_and_build.yml @@ -121,7 +121,7 @@ jobs: 2 1 1 - 10000 + 1 - name: Setup conda uses: conda-incubator/setup-miniconda@v2 with: