Skip to content

ref(package) replace appdirs with platformdirs in configuration and requirements files #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2025
Merged

ref(package) replace appdirs with platformdirs in configuration and requirements files #697

merged 3 commits into from
Aug 24, 2025
+6 −7

Conversation

hasansezertasan
Copy link
Contributor

Fixes: #696

Description

Replace appdirs with platformdirs and adjust related fields.

Tested with

I haven't tested with any device.

@hasansezertasan hasansezertasan mentioned this pull request Aug 22, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.50%. Comparing base (c702204) to head (069f2ca).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          21       21           
  Lines        1692     1692           
  Branches      266      266           
=======================================
  Hits         1379     1379           
  Misses        234      234           
  Partials       79       79
Flag Coverage Δ
unittests 81.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/escpos/config.py 83.67% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hasansezertasan
hasansezertasan commented Aug 23, 2025
View reviewed changes
@hasansezertasan hasansezertasan marked this pull request as ready for review August 24, 2025 21:57
@hasansezertasan hasansezertasan requested a review from belono August 24, 2025 21:57
@hasansezertasan
Copy link
Contributor Author

I believe this is good to go now @belono 😇.

patkan
patkan approved these changes Aug 24, 2025
View reviewed changes
Copy link
Member

@patkan patkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution! I approve this change :-)

@patkan patkan merged commit 1a780e8 into python-escpos:master Aug 24, 2025
15 checks passed
@hasansezertasan hasansezertasan deleted the ref/migrate-to-platformdirs branch August 25, 2025 02:21
@hasansezertasan
Copy link
Contributor Author

Thank you very much for the contribution! I approve this change :-)

Thank you @patkan for your quick response. Happy to help 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patkan patkan patkan approved these changes

@belono belono Awaiting requested review from belono

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

appdirs is deprecated, use platformdirs instead.
3 participants
@hasansezertasan @patkan @belono