Skip to content

[3.10] bpo-29753: revert 0d7ad9f (GH-19850) (GH-27085) #27086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2021
Merged

[3.10] bpo-29753: revert 0d7ad9f (GH-19850) (GH-27085) #27086

merged 1 commit into from
Jul 11, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 11, 2021 •
edited by bedevere-bot
Loading

This reverts commit 0d7ad9f as it has a regression.

See https://github.com/python/cpython/pull/19850GH-issuecomment-869410686
(cherry picked from commit e14d5ae)

Co-authored-by: Filipe Laíns lains@archlinux.org

https://bugs.python.org/issue29753

@FFY00 @miss-islington
bpo-29753: revert 0d7ad9f (pythonGH-19850) (pythonGH-27085)
9ce53ae 
This reverts commit 0d7ad9f as it has a regression.

See https://github.com/python/cpython/pull/19850GH-issuecomment-869410686
(cherry picked from commit e14d5ae)

Co-authored-by: Filipe Laíns <lains@archlinux.org>
@pablogsal pablogsal mentioned this pull request Jul 11, 2021
Merged
@miss-islington
Copy link
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 5 required status checks are expected..

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "bedevere/maintenance-branch-pr" is expected..

1 similar comment
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "bedevere/maintenance-branch-pr" is expected..

@miss-islington
Copy link
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "bedevere/maintenance-branch-pr" is expected..

1 similar comment
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Required status check "bedevere/maintenance-branch-pr" is expected..

@pablogsal pablogsal changed the title [3.10] bpo-29753: revert 0d7ad9f (GH-19850) (GH-27085) [3.10] bpo-29753: revert 0d7ad9f (GH-19850) (GH-27085) Jul 11, 2021
@miss-islington
Copy link
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@FFY00: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 42da46e into python:3.10 Jul 11, 2021
@miss-islington miss-islington deleted the backport-e14d5ae-3.10 branch July 11, 2021 17:47
@CharlesMachalow CharlesMachalow mannequin mentioned this pull request Oct 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot @FFY00