Skip to content

Make Play compatible with latest Scala #13020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Make Play compatible with latest Scala #13020

wants to merge 5 commits into from

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Dec 20, 2024 •
edited
Loading

This is not intended to be merged; however, we want Play to be compatible with newer Scala versions.

... the subsequent new LTS which will mostly likely be Scala 3.9. 1

Footnotes

  1. https://www.scala-lang.org/news/next-scala-lts-jdk.html ↩

@mkurz mkurz force-pushed the test_scala3.6.3 branch 2 times, most recently from a3d8cf0 to 51e41c2 Compare December 20, 2024 14:27
@mkurz mkurz mentioned this pull request Dec 20, 2024
Merged
This was referenced Dec 20, 2024
Merged
Merged
@mkurz mkurz changed the title Test Scala 3.6.3-RC1 Test Scala 3.6.4-RC1 Feb 20, 2025
@mkurz

This comment was marked as outdated.

Sign in to view
@mkurz mkurz changed the title Test Scala 3.6.4-RC1 Test Scala 3.6.4 Mar 10, 2025
@mkurz mkurz force-pushed the test_scala3.6.3 branch 2 times, most recently from 423c0fb to 34fe59b Compare March 10, 2025 12:34
@mkurz mkurz changed the title Test Scala 3.6.4 Test Scala 3.6.4 (make Play compatible with latest Scala) Mar 17, 2025
@mkurz mkurz changed the title Test Scala 3.6.4 (make Play compatible with latest Scala) Make Play compatible with latest Scala Mar 17, 2025
@ajafri2001
Copy link

ajafri2001 commented May 10, 2025 •
edited
Loading

@mkurz hi! I’m interested in working on these issues and would love to help make twirl templates more scala3 friendly. If you have any guidance or suggestions on how to get started, I’d really appreciate it! 🥰

regarding this issue, my current thinking is to somehow check whether the definition site uses implicit/using, and then try prepending using to whatever the last parameter () is at the call site. That said, this approach feels a bit crude/ugly, especially since the parser doesn’t currently recognize using. So maybe that's where I should start?

what would be the ideal way to approach this?

(LSP support for play specific files like twirl and routes are a part of my summer project so I have vested interest in making the experience better 😅)

@mkurz mkurz mentioned this pull request May 22, 2025
Closed
@mkurz mkurz force-pushed the test_scala3.6.3 branch from 34fe59b to e3636fd Compare July 8, 2025 11:38
@mkurz
Copy link
Member Author

mkurz commented Jul 8, 2025

All tests and scripted tests pass with 3.7.2-RC1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Play 4.0 (due 30st June 2025)
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkurz @ajafri2001