8364816: GetLastError() in os_windows.cpp should not store value to errno #26901
+18
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back toxaart! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, please consider the following changes:
In
os_windows.cppnn a few places results returned byGetLastError()are stored toerrno. However,errnohas no relation toGetLastError(), and their ranges are not the same.Results of
GetLastError()should be stored into variables of typeDWORD.Tested in tiers 1 - 3.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26901/head:pull/26901$ git checkout pull/26901Update a local copy of the PR:
$ git checkout pull/26901$ git pull https://git.openjdk.org/jdk.git pull/26901/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26901View PR using the GUI difftool:
$ git pr show -t 26901Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26901.diff