From 1ce69117f97b14b4f589528fc726872d31a7278a Mon Sep 17 00:00:00 2001 From: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com> Date: Tue, 18 Mar 2025 22:08:10 +0100 Subject: [PATCH] MNT: Move test for old ipython behavior to minver tests While not exactly a minver test, it's semantically related in that it changes rather old package versions. This should help declutter the test matrix and make the upcoming transition to newer ubuntu images and dropping python 3.10 simpler. --- .github/workflows/tests.yml | 7 +------ requirements/testing/minver.txt | 8 ++++++++ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 0b54e881e96d..8960e61e8f2c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -59,12 +59,7 @@ jobs: pyside6-ver: '==6.2.0' - os: ubuntu-20.04 python-version: '3.10' - # One CI run tests ipython/matplotlib-inline before backend mapping moved to mpl - extra-requirements: - -r requirements/testing/extra.txt - "ipython==7.29.0" - "ipykernel==5.5.6" - "matplotlib-inline<0.1.7" + extra-requirements: '-r requirements/testing/extra.txt' CFLAGS: "-fno-lto" # Ensure that disabling LTO works. # https://github.com/matplotlib/matplotlib/pull/26052#issuecomment-1574595954 # https://www.riverbankcomputing.com/pipermail/pyqt/2023-November/045606.html diff --git a/requirements/testing/minver.txt b/requirements/testing/minver.txt index 061683eea753..3cdf095dffaa 100644 --- a/requirements/testing/minver.txt +++ b/requirements/testing/minver.txt @@ -13,3 +13,11 @@ pillow==9.0.1 pyparsing==2.3.1 pytest==7.0.0 python-dateutil==2.7 + +# Test ipython/matplotlib-inline before backend mapping moved to mpl. +# This should be tested for a reasonably long transition period, +# but we will eventually remove the test when we no longer support +# ipython/matplotlib-inline versions from before the transition. +ipython==7.29.0 +ipykernel==5.5.6 +matplotlib-inline<0.1.7