Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: matlab-deep-learning/llms-with-matlab
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.0.0
Choose a base ref
...
head repository: matlab-deep-learning/llms-with-matlab
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.0
Choose a head ref
  • 16 commits
  • 32 files changed
  • 3 contributors

Commits on Oct 30, 2024

  1. Drop OPENAI_KEY

    For some reason, we used both `OPENAI_KEY` and `OPENAI_API_KEY` env variables, expecting them to have the same values. Drop the `OPENAI_KEY` one, since we document our use of `OPENAI_API_KEY`.
    ccreutzi committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    e16afaf View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Disable test point

    This test point runs fine on multiple dev machines (with updated Ollama), but fails in CI with an internal error to Ollama/llama.cpp:
    
    ```
      ================================================================================
      Error occurred in tollamaChat/generateWithImages and it did not run to completion.
          ---------
          Error ID:
          ---------
          'llms:apiReturnedError'
          --------------
          Error Details:
          --------------
          Error using ollamaChat/generate (line 238)
          Server returned error indicating: "an unknown error was encountered while
          running the model GGML_ASSERT(i01 >= 0 && i01 < ne01) failed"
    
          Error in tollamaChat>@(~)generate(chat,messages) (line 136)
                      text = arrayfun(@(~) generate(chat,messages), 1:5,
                      UniformOutput=false);
    
          Error in tollamaChat/generateWithImages (line 136)
                      text = arrayfun(@(~) generate(chat,messages), 1:5,
                      UniformOutput=false);
      ================================================================================
    ```
    
    See also ollama/ollama#7288
    ccreutzi committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    353d807 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Configuration menu
    Copy the full SHA
    739b5a2 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    5b3ac4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6eb862e View commit details
    Browse the repository at this point in the history
  3. Add Enrico as code owner

    ccreutzi committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b420b8b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #82 from matlab-deep-learning/removeCodeCov

    Remove configuration for codecov
    vpapanasta authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3dfac40 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Disallow dlarray in prototype

    Using `dlarray` in a prototype results in `dlarray` in the output, but without the dimension labels. Reason: `cast(X,'like',Y)` behaves that way for `dlarray` `Y`.
    
    Given that we do not return higher-dimensional data anyway, it is questionable whether there is any reason one would want to allow `dlarray` in prototypes. Not handling them properly means we are better off disabling them altogether.
    
    Without a dependency on Deep Learning Toolbox, we cannot have an automated test point for this change, unfortunately.
    ccreutzi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    e6199f3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #83 from matlab-deep-learning/add-enrico

    Add Enrico as code owner
    ccreutzi authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8d4ca80 View commit details
    Browse the repository at this point in the history
  3. ToolChoice="none" for azureChat

    `azureChat` should support `ToolChoice="none"`
    ccreutzi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c5e2ef1 View commit details
    Browse the repository at this point in the history
  4. Return tool calls properly in azureChat

    Make `azureChat` handle tool calls returned the same way we do in `openAIChat`.
    ccreutzi committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    245e4b0 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Stop warning in constructor for ResponseFormat="json"

    Since we now throw an error when `ResponseFormat="json"` is used without
    the required `"json"` in the inputs, we can stop warning in the constructor.
    With the previous state, users got a warning they could not avoid, even
    in code doing everything correctly.
    ccreutzi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2d0ec2d View commit details
    Browse the repository at this point in the history
  2. Sentiment to structured

    change example to using structured output
    ccreutzi committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3b1db9d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2024

  1. Structured ollama

    * Activate structured output for ollamaChat
    * Update documentation
    ccreutzi committed Dec 13, 2024
    Configuration menu
    Copy the full SHA
    44a3679 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8bfd78 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25b8ffc View commit details
    Browse the repository at this point in the history
Loading