A test case for Issue #2565. #2569
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just takes the PoC from that issue and wraps it into a standard test. I've not yet used this to reproduce the issue, much less to diagnose the root cause.
|
Ah. The PoC from #2565 only reproduces if libarchive is built with CRC checks disabled. I guess I need to fix the CRCs in this example so it works even in a standard build? Hmmm.... |
|
Hi @kientzle, I have cherry-picked your test case addition into my PR #2599 which fixes the issue as well. The input file has been reduced a bit and checksums adjusted. The rar file header stated that a directory is contained. I have modified it to contain a file, which allows a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just takes the PoC from Issue #2565 and wraps it in a standard test.
I've not yet used this to reproduce the issue, much less to diagnose the root cause.