fix test expect error

jdeniau · jdeniau · commit 698537fb6e14 · 2025-06-09T22:33:48.000Z
diff --git a/__tests__/Conversion.ts b/__tests__/Conversion.ts
@@ -1,5 +1,13 @@
 import { describe, expect, it } from '@jest/globals';
-import { fromJS, is, List, Map, OrderedMap, Record } from 'immutable';
+import {
+  type Collection,
+  fromJS,
+  is,
+  List,
+  Map,
+  OrderedMap,
+  Record,
+} from 'immutable';
 import fc, { type JsonValue } from 'fast-check';
 
 describe('Conversion', () => {
@@ -126,7 +134,7 @@ describe('Conversion', () => {
           // @ts-expect-error -- to convert to real typing
           return new Point(sequence);
         }
-        // @ts-expect-error unknown any type
+
         return Array.isArray(this[key])
           ? sequence.toList()
           : sequence.toOrderedMap();
@@ -145,7 +153,7 @@ describe('Conversion', () => {
       function (this: typeof js, key: any, sequence, keypath) {
         expect(arguments.length).toBe(3);
         paths.push(keypath);
-        // @ts-expect-error unknown any type
+
         return Array.isArray(this[key])
           ? sequence.toList()
           : sequence.toOrderedMap();
diff --git a/__tests__/slice.ts b/__tests__/slice.ts
@@ -234,8 +234,9 @@ describe('slice', () => {
         (valuesLen, args) => {
           const a = Range(0, valuesLen).toArray();
           const v = List(a);
-          const slicedV = v.slice.apply(v, args);
-          const slicedA = a.slice.apply(a, args);
+
+          const slicedV = v.slice(...args);
+          const slicedA = a.slice(...args);
           expect(slicedV.toArray()).toEqual(slicedA);
         }
       )
@@ -251,8 +252,8 @@ describe('slice', () => {
           const a: Array<number> = [];
           entries.forEach((entry) => (a[entry[0]] = entry[1]));
           const s = Seq(a);
-          const slicedS = s.slice.apply(s, args);
-          const slicedA = a.slice.apply(a, args);
+          const slicedS = s.slice(...args);
+          const slicedA = a.slice(...args);
           expect(slicedS.toArray()).toEqual(slicedA);
         }
       )
diff --git a/__tests__/splice.ts b/__tests__/splice.ts
@@ -51,12 +51,15 @@ describe('splice', () => {
     fc.assert(
       fc.property(
         fc.array(fc.integer()),
-        fc.array(fc.sparseArray(fc.integer())),
-        (values, args) => {
+        fc.integer(),
+        fc.integer(),
+        fc.array(fc.integer()),
+        (values, index, removeNum, insertValues) => {
           const v = List(values);
           const a = values.slice(); // clone
-          const splicedV = v.splice.apply(v, args); // persistent
-          a.splice.apply(a, args); // mutative
+
+          const splicedV = v.splice(index, removeNum, ...insertValues); // persistent
+          a.splice(index, removeNum, ...insertValues); // mutative
           expect(splicedV.toArray()).toEqual(a);
         }
       )
diff --git a/__tests__/updateIn.ts b/__tests__/updateIn.ts
@@ -81,6 +81,7 @@ describe('updateIn', () => {
         this.length = values.length;
 
         for (let i = 0; i < values.length; i++) {
+          // @ts-expect-error -- TypeScript does not know that this is a valid index
           this[i] = values[i];
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -234,8 +234,9 @@ describe('slice', () => {`
`234`	`234`	`(valuesLen, args) => {`
`235`	`235`	`const a = Range(0, valuesLen).toArray();`
`236`	`236`	`const v = List(a);`
`237`		`- const slicedV = v.slice.apply(v, args);`
`238`		`- const slicedA = a.slice.apply(a, args);`
	`237`	`+`
	`238`	`+ const slicedV = v.slice(...args);`
	`239`	`+ const slicedA = a.slice(...args);`
`239`	`240`	`expect(slicedV.toArray()).toEqual(slicedA);`
`240`	`241`	`}`
`241`	`242`	`)`
`@@ -251,8 +252,8 @@ describe('slice', () => {`
`251`	`252`	`const a: Array<number> = [];`
`252`	`253`	`entries.forEach((entry) => (a[entry[0]] = entry[1]));`
`253`	`254`	`const s = Seq(a);`
`254`		`- const slicedS = s.slice.apply(s, args);`
`255`		`- const slicedA = a.slice.apply(a, args);`
	`255`	`+ const slicedS = s.slice(...args);`
	`256`	`+ const slicedA = a.slice(...args);`
`256`	`257`	`expect(slicedS.toArray()).toEqual(slicedA);`
`257`	`258`	`}`
`258`	`259`	`)`
Original file line number	Diff line number	Diff line change
`@@ -81,6 +81,7 @@ describe('updateIn', () => {`
`81`	`81`	`this.length = values.length;`
`82`	`82`
`83`	`83`	`for (let i = 0; i < values.length; i++) {`
	`84`	`+ // @ts-expect-error -- TypeScript does not know that this is a valid index`
`84`	`85`	`this[i] = values[i];`
`85`	`86`	`}`
`86`	`87`	`}`