Merge pull request #1327 from nevkontakte/quicker-tests

nevkontakte · web-flow · commit d07fd617e2c1 · 2024-07-23T08:19:04.000+01:00
Make slow stdlib tests faster.
diff --git a/compiler/natives/src/crypto/ed25519/ed25519vectors_test.go b/compiler/natives/src/crypto/ed25519/ed25519vectors_test.go
diff --git a/compiler/natives/src/crypto/ed25519/internal/edwards25519/field/fe_test.go b/compiler/natives/src/crypto/ed25519/internal/edwards25519/field/fe_test.go
diff --git a/compiler/natives/src/crypto/ed25519/internal/edwards25519/scalar_test.go b/compiler/natives/src/crypto/ed25519/internal/edwards25519/scalar_test.go
diff --git a/compiler/natives/src/crypto/internal/edwards25519/field/fe_alias_test.go b/compiler/natives/src/crypto/internal/edwards25519/field/fe_alias_test.go
@@ -0,0 +1,16 @@
+//go:build js
+
+package field
+
+import (
+	"testing"
+	"testing/quick"
+)
+
+//gopherjs:keep-original
+func TestAliasing(t *testing.T) {
+	// The test heavily uses 64-bit math, which is slow under GopherJS. Reducing
+	// the number of iterations makes run time more manageable.
+	t.Cleanup(quick.GopherJSInternalMaxCountCap(100))
+	_gopherjs_original_TestAliasing(t)
+}
diff --git a/compiler/natives/src/crypto/internal/edwards25519/field/fe_test.go b/compiler/natives/src/crypto/internal/edwards25519/field/fe_test.go
@@ -0,0 +1,9 @@
+//go:build js
+
+package field
+
+import "testing/quick"
+
+// Tests in this package use 64-bit math, which is slow under GopherJS. To keep
+// test run time reasonable, we reduce the number of test iterations.
+var quickCheckConfig1024 = &quick.Config{MaxCountScale: 10}
diff --git a/compiler/natives/src/crypto/internal/edwards25519/scalar_test.go b/compiler/natives/src/crypto/internal/edwards25519/scalar_test.go
@@ -0,0 +1,9 @@
+//go:build js
+
+package edwards25519
+
+import "testing/quick"
+
+// Tests in this package use 64-bit math, which is slow under GopherJS. To keep
+// test run time reasonable, we reduce the number of test iterations.
+var quickCheckConfig1024 = &quick.Config{MaxCountScale: 1}
diff --git a/compiler/natives/src/crypto/internal/edwards25519/scalarmult_test.go b/compiler/natives/src/crypto/internal/edwards25519/scalarmult_test.go
@@ -0,0 +1,9 @@
+//go:build js
+
+package edwards25519
+
+import "testing/quick"
+
+// Tests in this package use 64-bit math, which is slow under GopherJS. To keep
+// test run time reasonable, we reduce the number of test iterations.
+var quickCheckConfig32 = &quick.Config{MaxCountScale: 0.5}
diff --git a/compiler/natives/src/crypto/x509/name_constraints_test.go b/compiler/natives/src/crypto/x509/name_constraints_test.go
@@ -0,0 +1,16 @@
+//go:build js
+
+package x509
+
+import "testing"
+
+//gopherjs:keep-original
+func TestConstraintCases(t *testing.T) {
+	if testing.Short() {
+		// These tests are slow under GopherJS. Since GopherJS doesn't touch
+		// business logic behind them, there's little value in running them all.
+		// Instead, in the short mode we just just the first few as a smoke test.
+		nameConstraintsTests = nameConstraintsTests[0:5]
+	}
+	_gopherjs_original_TestConstraintCases(t)
+}
diff --git a/compiler/natives/src/image/gif/fuzz_test.go b/compiler/natives/src/image/gif/fuzz_test.go
@@ -0,0 +1,14 @@
+//go:build js
+
+package gif
+
+import "testing"
+
+//gopherjs:keep-original
+func FuzzDecode(t *testing.F) {
+	if testing.Short() {
+		t.Skip("FuzzDecode is slow, skipping in the short mode.")
+	}
+
+	_gopherjs_original_FuzzDecode(t)
+}
diff --git a/compiler/natives/src/testing/quick/quick.go b/compiler/natives/src/testing/quick/quick.go
@@ -0,0 +1,37 @@
+//go:build js
+
+package quick
+
+var maxCountCap int = 0
+
+// GopherJSInternalMaxCountCap sets an upper bound of iterations quick test may
+// perform. THIS IS GOPHERJS-INTERNAL API, DO NOT USE IT OUTSIDE OF THE GOPHERJS
+// CODEBASE, IT MAY CHANGE OR DISAPPEAR WITHOUT NOTICE.
+//
+// This function can be used to limit run time of standard library tests which
+// use testing/quick with too many iterations for GopherJS to complete in a
+// reasonable amount of time. This is a better compromise than disabling a slow
+// test entirely.
+//
+//     //gopherjs:keep-original
+//     func TestFoo(t *testing.T) {
+//         t.Cleanup(quick.GopherJSInternalMaxCountCap(100))
+//         _gopherjs_original_TestFoo(t)
+//     }
+
+func GopherJSInternalMaxCountCap(newCap int) (restore func()) {
+	previousCap := maxCountCap
+	maxCountCap = newCap
+	return func() {
+		maxCountCap = previousCap
+	}
+}
+
+//gopherjs:keep-original
+func (c *Config) getMaxCount() (maxCount int) {
+	maxCount = c._gopherjs_original_getMaxCount()
+	if maxCountCap > 0 && maxCount > maxCountCap {
+		maxCount = maxCountCap
+	}
+	return maxCount
+}
