Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-jose/go-jose
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.1.1
Choose a base ref
...
head repository: go-jose/go-jose
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.2
Choose a head ref
  • 6 commits
  • 19 files changed
  • 7 contributors

Commits on Jul 17, 2025

  1. Update go-jose documentation (#198)

    - Remove CHANGELOG.md
    
    We haven't been good about keeping it up-to-date.
    Consult git history or Github Releases for change information
    
    Fixes #196
    
    - Remove broken shields.io tests status.
    
    The test status shield isn't working.
    Consult the Github Actions output to see current test status.
    
    - Clarify different go-jose versions
    
    More aggressively recommend users migrate to Version 4, and include
    notes about encoding/json/v2 for the Version 5 of go-jose. Document that
    we will support the two current Golang releases on V4.
    
    Fixes #184
    
    - Fixup markdown table borders
    mcpherrinm authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    6acb8e6 View commit details
    Browse the repository at this point in the history
  2. Remove dependency on testify (#197)

    This PR removes the dependency on testify. Unit tests of the new code
    are included.
    
    **Why remove testify:**
    
    - testify is a dependency (and has indirect dependencies)
    - testify uses go-spew which is not maintained anymore (see
    stretchr/testify#1638)
    - go-spew is in a 'not allowed' list in Kubernetes (see
    kubernetes/kubernetes#103942) and therefore
    kubernetes can't use go-jose v4 (see
    kubernetes/kubernetes#123252)
    - Equal was used to compare complex structs, but Equal in testify
    doesn't fully compare values, see
    stretchr/testify#1616
    - removing testify would remove the dependencies on external projects,
    reducing operational risk, as go-jose has a lot of users
    
    ---------
    
    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
    Co-authored-by: Matthew McPherrin <mattm@letsencrypt.org>
    Co-authored-by: Jacob Hoffman-Andrews <github@hoffman-andrews.com>
    4 people authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    10dbdce View commit details
    Browse the repository at this point in the history
  3. jwk: list all missing fields on error (#195)

    The switch statement is exited subsequent to the first condition that
    evaluates to true, yet it is evident from the context that the intention
    was to cover all possibilities.
    
    Found by PostgresPro
    
    Related: 98e5a54 ("Print all missing fields at once")
    ProjectMutilation authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    6a17172 View commit details
    Browse the repository at this point in the history
  4. jwk: JSONWebKey.UnmarshalJSON can return ErrUnsupportedKeyType (#191)

    Ultimately we want to ignore unsupported key types in JSONWebKeySets
    (#26 / #130), but we are blocked on doing a breaking change release.
    In the meantime, we can have JSONWebKey (the singular version)
    return ErrUnsupportedKeyType.
    
    This allows users to write their own JWKS umarshalling method to
    ignore unsupported key types, eg.
    https://github.com/zitadel/oidc/blob/045b59e5a55be97ba180fdaae96fb66302a03353/pkg/client/rp/jwks.go#L221-L235.
    fprojetto authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    e2cde04 View commit details
    Browse the repository at this point in the history
  5. jwe: accept non-pointer JSONWebKey in Recipient (#200)

    JSONWebKey is marked as a valid type in Recipient but was rejected further down the line when calling `makeJWERecipient()`.
    alvarolivie authored Jul 17, 2025
    Configuration menu
    Copy the full SHA
    3a80e13 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2025

  1. testutils/assert: remove True, Nil, NotNil (#202)

    These functions were used few places, and could generally be replaced
    with a simple `if` and a more informative error message, or a more
    specific assert function.
    
    Follow up to #197
    jsha authored Jul 18, 2025
    Configuration menu
    Copy the full SHA
    a1565a4 View commit details
    Browse the repository at this point in the history
Loading