From ebe1ecf033c574142cc78401c71dd2b13d9d2b70 Mon Sep 17 00:00:00 2001 From: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Date: Fri, 22 Aug 2025 12:09:59 -0700 Subject: [PATCH 1/2] buh --- .../flutter/lib/src/widgets/framework.dart | 1 - .../test/widgets/reparent_state_test.dart | 18 ------------------ 2 files changed, 19 deletions(-) diff --git a/packages/flutter/lib/src/widgets/framework.dart b/packages/flutter/lib/src/widgets/framework.dart index 95f4bb07cbd5b..1030953a57169 100644 --- a/packages/flutter/lib/src/widgets/framework.dart +++ b/packages/flutter/lib/src/widgets/framework.dart @@ -6016,7 +6016,6 @@ class StatefulElement extends ComponentElement { // resources allocated in the build method, we have to rebuild the widget // so that its State can reallocate its resources. assert(_lifecycleState == _ElementLifecycle.active); // otherwise markNeedsBuild is a no-op - markNeedsBuild(); } @override diff --git a/packages/flutter/test/widgets/reparent_state_test.dart b/packages/flutter/test/widgets/reparent_state_test.dart index 232a210f71b6b..5bfdc8f863aef 100644 --- a/packages/flutter/test/widgets/reparent_state_test.dart +++ b/packages/flutter/test/widgets/reparent_state_test.dart @@ -325,24 +325,6 @@ void main() { expect(keyState.marker, equals('marked')); }); - testWidgets('Deactivate implies build', (WidgetTester tester) async { - final GlobalKey key = GlobalKey(); - final List log = []; - final DeactivateLogger logger = DeactivateLogger(key: key, log: log); - - await tester.pumpWidget(Container(key: UniqueKey(), child: logger)); - - expect(log, equals(['build'])); - - await tester.pumpWidget(Container(key: UniqueKey(), child: logger)); - - expect(log, equals(['build', 'deactivate', 'build'])); - log.clear(); - - await tester.pump(); - expect(log, isEmpty); - }); - testWidgets('Reparenting with multiple moves', (WidgetTester tester) async { final GlobalKey key1 = GlobalKey(); final GlobalKey key2 = GlobalKey(); From 9c47eddc9b131675397b227a555a047872898726 Mon Sep 17 00:00:00 2001 From: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Date: Fri, 22 Aug 2025 13:37:10 -0700 Subject: [PATCH 2/2] cuh --- .../test/widgets/reparent_state_test.dart | 23 ------------------- 1 file changed, 23 deletions(-) diff --git a/packages/flutter/test/widgets/reparent_state_test.dart b/packages/flutter/test/widgets/reparent_state_test.dart index 5bfdc8f863aef..ba3ca91d47e33 100644 --- a/packages/flutter/test/widgets/reparent_state_test.dart +++ b/packages/flutter/test/widgets/reparent_state_test.dart @@ -23,29 +23,6 @@ class StateMarkerState extends State { } } -class DeactivateLogger extends StatefulWidget { - const DeactivateLogger({required Key super.key, required this.log}); - - final List log; - - @override - DeactivateLoggerState createState() => DeactivateLoggerState(); -} - -class DeactivateLoggerState extends State { - @override - void deactivate() { - widget.log.add('deactivate'); - super.deactivate(); - } - - @override - Widget build(BuildContext context) { - widget.log.add('build'); - return Container(); - } -} - void main() { testWidgets('can reparent state', (WidgetTester tester) async { final GlobalKey left = GlobalKey();