-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Closed
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsbrowser: edgeonly manifests in Edge (Chromium-based)only manifests in Edge (Chromium-based)c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team
Description
Some tests in test/window_test.dart
are skipped in Safari.
In Safari the test passes in isolation. However, when running all tests at once, the whole batch fails. It's hard to tell why. There seems to be some cross-tests state pollution going on. Perhaps the issue is that tests run in an <iframe>
and location history is modifying some global state.
Sample failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8804297826222711985/+/u/test:_Run_tests_on_macOS_Safari/stdout
Edit by @yjbanov: refined this bug report with more details.
Aravinthan-Subramanian
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work lista: tests"flutter test", flutter_test, or one of our tests"flutter test", flutter_test, or one of our testsbrowser: edgeonly manifests in Edge (Chromium-based)only manifests in Edge (Chromium-based)c: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.frameworkflutter/packages/flutter repository. See also f: labels.flutter/packages/flutter repository. See also f: labels.platform-webWeb applications specificallyWeb applications specificallyteam-webOwned by Web platform teamOwned by Web platform teamtriaged-webTriaged by Web platform teamTriaged by Web platform team