-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listplatform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Description
We have this code:
flutter/packages/flutter_tools/bin/xcode_backend.dart
Lines 132 to 139 in 5483fef
// Stream stderr to the Flutter build process. | |
// When in verbose mode, `echoError` above will show the logs. So only | |
// stream if not in verbose mode to avoid duplicate logs. | |
// Also, only stream if exitCode is 0 since errors are handled separately | |
// by the tool on failure. | |
if (!verbose && exitCode == 0) { | |
streamOutput(errorOutput.toString()); | |
} |
We check exitCode
of current process, not result.exitCode
of the subprocess (e.g. plutil).
I think this check shouldn't be necessary, because if exitCode is not 0, then the current process is already terminated (xcode_backend
never change its own exitCode without exiting the process).
It should be safe to just do
if (!verbose) {
// ...
}
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listplatform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform teamTriaged by iOS platform team