-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Open
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listplatform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform teamTriaged by iOS platform team
Description
Steps to reproduce
I was just reading the code, and there is a logic error here:
flutter/packages/flutter_tools/bin/xcode_backend.dart
Lines 419 to 435 in 5b78ecc
ProcessResult result = runSync('plutil', <String>[ | |
'-extract', | |
'NSBonjourServices', | |
'xml1', | |
'-o', | |
'-', | |
builtProductsPlist, | |
], allowFail: true); | |
if (result.exitCode == 0) { | |
runSync('plutil', <String>[ | |
'-insert', | |
'NSBonjourServices.0', | |
'-string', | |
'_dartVmService._tcp', | |
builtProductsPlist, | |
]); | |
} else { |
If the bonjour services is already setup properly, we shouldn't add duplicate _dartVmService._tcp
entry to it.
Expected results
No duplicate entries in bonjour services
Actual results
I wrote a simple test and got duplicate values:
'\t<key>NSBonjourServices</key>\n'
'\t<array>\n'
'\t\t<string>_dartVmService._tcp</string>\n'
'\t\t<string>_dartVmService._tcp</string>\n'
'\t\t<string>_bogus._tcp</string>\n'
'\t</array>\n'
Code sample
NA
Screenshots or Video
NA
Logs
NA
Flutter Doctor output
NA
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listplatform-iosiOS applications specificallyiOS applications specificallyteam-iosOwned by iOS platform teamOwned by iOS platform teamtoolAffects the "flutter" command-line tool. See also t: labels.Affects the "flutter" command-line tool. See also t: labels.triaged-iosTriaged by iOS platform teamTriaged by iOS platform team