Skip to content

How to add a threshold for golden test with VmServiceProxyGoldenFileComparator #172207

@GiacomoPignoni

Description

@GiacomoPignoni

I've some integration test that also use the golden file comparator.
When running on a device the golden test is made with VmServiceProxyGoldenFileComparator but, as I understand, is not possibile to have threshold.

I saw that it's possible to add it rewriting the LocalFileComparator but how can I do it for the VmServiceProxyGoldenFileComparator? Because the operation is not inside this class but somewhere else and the result is only a boolean value

Metadata

Metadata

Assignees

No one assigned

    Labels

    a: tests"flutter test", flutter_test, or one of our testsc: proposalA detailed proposal for a change to Flutterd: api docsIssues with https://api.flutter.dev/f: integration_testThe flutter/packages/integration_test pluginframeworkflutter/packages/flutter repository. See also f: labels.r: solvedIssue is closed as solvedteam-toolOwned by Flutter Tool teamworkaround availableThere is a workaround available to overcome the issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions