[3.35] Do not include :unittests unless enable_unittests (#173734)

flutteractionsbot · web-flow · commit 1e9a811bf8e7 · 2025-08-13T23:35:25.000Z
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #173728 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples N/A ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Skips building Android unit tests during the engine release builder ### Workaround: Is there a workaround for this issue? No ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? The release builder step works.
diff --git a/engine/src/flutter/BUILD.gn b/engine/src/flutter/BUILD.gn
@@ -78,10 +78,12 @@ group("flutter") {
 
   if (!is_qnx) {
     public_deps = [
-      ":unittests",
       "//flutter/shell/platform/embedder:flutter_engine",
       "//flutter/sky",
     ]
+    if (enable_unittests) {
+      public_deps += [ ":unittests" ]
+    }
   }
 
   # Ensure the example for a sample embedder compiles.

Original file line number	Diff line number	Diff line change
`@@ -78,10 +78,12 @@ group("flutter") {`
`78`	`78`
`79`	`79`	`if (!is_qnx) {`
`80`	`80`	`public_deps = [`
`81`		`- ":unittests",`
`82`	`81`	`"//flutter/shell/platform/embedder:flutter_engine",`
`83`	`82`	`"//flutter/sky",`
`84`	`83`	`]`
	`84`	`+ if (enable_unittests) {`
	`85`	`+ public_deps += [ ":unittests" ]`
	`86`	`+ }`
`85`	`87`	`}`
`86`	`88`
`87`	`89`	`# Ensure the example for a sample embedder compiles.`