$router->get() vs $router->post() [Method not allowed] #654

joho1968 · 2025-07-15T13:05:39Z

joho1968
Jul 15, 2025

Two questions really:

Are there more specific error handlers than notFound, e.g. one for methodNotAllowed? 🤔
Why am I getting a Method Not Allowed error when I POST here, but not when I GET? 🤔

$router->post( '/login', function() use ( $app, $router, $security, $config ) {
    $admin = new AdminController( $app, $router, $security, $config );
    $admin->login();
});

$router->get( '/login', function() use ( $app, $router, $security, $config ) {
    $admin = new AdminController( $app, $router, $security, $config );
    $admin->loginForm();
});

n0nag0n · 2025-07-16T02:05:07Z

n0nag0n
Jul 16, 2025
Maintainer

So I see why it does it. In the core code, it stores things by the url and then the method. Technically how you coded that ends up with this result.

// internal storage of routes
$routes = [
  0 => [
    'url' => '/login'
    'methods' => 'POST'
  ],
  1 => [
    'url' => '/login'
    'methods' => 'GET'
  ],
];

So what happens is it goes through each array key to find the url. Since it matches the first one, then it checks the methods and since GET isn't there that's why....

I'll think through on how to adjust it moving forward.

And no, there is no method like a methodNotFound(). This is probably odd, but you could overwrite the halt() method with $app->map('halt', function($status, $message) { /* code */ }); and capture the error to do something custom with it if you wanted.

0 replies

n0nag0n · 2025-07-16T03:34:37Z

n0nag0n
Jul 16, 2025
Maintainer

Actually now that I'm able to test it locally, it actually is working for me. I'm not getting any errors. This is my code on the latest version of Flight....maybe you need to update?

<?php

declare(strict_types=1);

require 'flight/autoload.php';
Flight::route('POST /login', function () {
	echo 'hello world from POST!';
});

Flight::route('GET /login', function () {
    echo 'hello world from GET!';
});


Flight::start();

0 replies

joho1968 · 2025-07-23T12:29:24Z

joho1968
Jul 23, 2025
Author

I just did a composer update, which yielded:

- Downloading flightphp/core (v3.17.0)
- Downloading nette/utils (v4.0.7)
- Downloading latte/latte (v3.0.23)
- Upgrading flightphp/core (v3.15.2 => v3.17.0): Extracting archive
- Upgrading nette/utils (v4.0.6 => v4.0.7): Extracting archive
- Upgrading latte/latte (v3.0.21 => v3.0.23): Extracting archive

But unfortunately the problem persists. I'm not sure why it works for you though, if you haven't changed the way the array is scanned 🤔

And, when you scan the array, should you really only match the URL if methods is not empty? I would consider an empty methods field to mean "all", and a non matching methods to make it skip to the next entry. Setting an indicator that you did find at least one URL match would let you throw the methodNotAllowed() after you've scanned all endpoints/URLs.

With, for example, and API, it's quite common to have different code handle different methods, even if it's the same endpoint.

1 reply

n0nag0n Jul 27, 2025
Maintainer

Just curious if the code sample that I provided, does that work for you in it's own file? I'm curious if something else in your environment is affecting it or something.

joho1968 · 2025-07-29T07:00:34Z

joho1968
Jul 29, 2025
Author

Well, my "bootstrap" looks a bit different, hence my code. It looks something like this:

bootstrap.php

$app = Flight::app();
$router = $app->router();
require_once 'routes.inc.php';
$app->start();

So I'm not adding the endpoints exactly like you are. But I don't quite see why/how that would make a difference 🤔

0 replies

joho1968 · 2025-07-31T07:23:46Z

joho1968
Jul 31, 2025
Author

Walking through the routes like this:

$router->reset();
do {
    $r = $router->current();
    if ( $r !== false ) {
        error_log( var_export( $r, true ) );
    }
    $router->next();
} while ( $r !== false );

Yields this:

\flight\net\Route::__set_state(array(
   'pattern' => '/login',
   'callback' => 
  \Closure::__set_state(array(
  )),
   'methods' => 
  array (
    0 => 'POST',
  ),
   'params' => 
  array (
  ),
   'regex' => NULL,
   'splat' => '',
   'pass' => false,
   'alias' => '',
   'middleware' => 
  array (
  ),
   'is_streamed' => false,
   'streamed_headers' => 
  array (
  ),
))
\flight\net\Route::__set_state(array(
   'pattern' => '/login',
   'callback' => 
  \Closure::__set_state(array(
  )),
   'methods' => 
  array (
    0 => 'GET',
    1 => 'HEAD',
  ),
   'params' => 
  array (
  ),
   'regex' => NULL,
   'splat' => '',
   'pass' => false,
   'alias' => '',
   'middleware' => 
  array (
  ),
   'is_streamed' => false,
   'streamed_headers' => 
  array (
  ),
))

So it's registering them correctly, but apparently something fails while parsing them 🤔

But if the parser considers that an URL match is finite, and not URL + METHOD, then I guess it's obvious where/why/how the "issue" occurs.

0 replies

joho1968 · 2025-07-31T07:40:01Z

joho1968
Jul 31, 2025
Author

In Router.php, the route() function does look like it should handle multiple routes with the same URL but different methods though. So after finding this, I really don't understand why it doesn't work 🙄

public function route(Request $request)
{
        while ($route = $this->current()) {
            $urlMatches = $route->matchUrl($request->url, $this->caseSensitive);
            $methodMatches = $route->matchMethod($request->method);
            if ($urlMatches === true && $methodMatches === true) {
                $this->executedRoute = $route;
                return $route;
                // capture the route but don't execute it. We'll use this in Engine->start() to throw a 405
            } elseif ($urlMatches === true && $methodMatches === false) {
                $this->executedRoute = $route;
            }
            $this->next();
        }

        return false;
}

0 replies

joho1968 · 2025-07-31T07:50:58Z

joho1968
Jul 31, 2025
Author

After going backwards, and also reading the above code, I think I found a typo (on my side). Mea culpa as they say 🫤

1 reply

n0nag0n Jul 31, 2025
Maintainer

Glad you were able to figure out though! I've done that so many times where I swear it was something else......and then it was me.......again 🤣

$router->get() vs $router->post() [Method not allowed] #654

Uh oh!

joho1968 Jul 15, 2025

Replies: 7 comments · 2 replies

Uh oh!

n0nag0n Jul 16, 2025 Maintainer

Uh oh!

n0nag0n Jul 16, 2025 Maintainer

Uh oh!

joho1968 Jul 23, 2025 Author

Uh oh!

n0nag0n Jul 27, 2025 Maintainer

Uh oh!

Uh oh!

joho1968 Jul 29, 2025 Author

Uh oh!

joho1968 Jul 31, 2025 Author

Uh oh!

joho1968 Jul 31, 2025 Author

Uh oh!

joho1968 Jul 31, 2025 Author

Uh oh!

n0nag0n Jul 31, 2025 Maintainer

joho1968
Jul 15, 2025

Replies: 7 comments 2 replies

n0nag0n
Jul 16, 2025
Maintainer

n0nag0n
Jul 16, 2025
Maintainer

joho1968
Jul 23, 2025
Author

n0nag0n Jul 27, 2025
Maintainer

joho1968
Jul 29, 2025
Author

joho1968
Jul 31, 2025
Author

joho1968
Jul 31, 2025
Author

joho1968
Jul 31, 2025
Author

n0nag0n Jul 31, 2025
Maintainer