From a879ffd59ebda08c537d72bd75acb9f923a5d809 Mon Sep 17 00:00:00 2001 From: kushalkolar Date: Fri, 30 Jun 2023 16:22:41 -0400 Subject: [PATCH 1/2] min version pins for numpy, jupyter-rfb, ipywidgets numpy < 1.23 causes issues with type annotations in the form: -> np.ndarray[Graphic] --- setup.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/setup.py b/setup.py index c9d5d6936..990efb11d 100644 --- a/setup.py +++ b/setup.py @@ -3,8 +3,8 @@ install_requires = [ - 'numpy', - 'pygfx>=0.1.13', + "numpy>=1.23.0", + "pygfx>=0.1.13", ] @@ -13,13 +13,15 @@ "sphinx", "pydata-sphinx-theme<0.10.0", "glfw", - "jupyter_rfb" # required so ImageWidget docs show up + "jupyter-rfb>=0.4.1" # required so ImageWidget docs show up + "ipywidgets>=8.0.0,<9" ], "notebook": [ - 'jupyterlab', - 'jupyter-rfb', + "jupyterlab", + "jupyter-rfb>=0.4.1", + "ipywidgets>=8.0.0,<9" ], "tests": @@ -29,7 +31,8 @@ "scipy", "imageio", "jupyterlab", - "jupyter-rfb", + "jupyter-rfb>=0.4.1", + "ipywidgets>=8.0.0,<9", "scikit-learn", "tqdm" ] From 4a273f8efd95aa8446ceca4bf3ce098e39f388dc Mon Sep 17 00:00:00 2001 From: Kushal Kolar Date: Sat, 1 Jul 2023 00:43:11 -0400 Subject: [PATCH 2/2] forgot a comma --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 990efb11d..f06183a60 100644 --- a/setup.py +++ b/setup.py @@ -13,7 +13,7 @@ "sphinx", "pydata-sphinx-theme<0.10.0", "glfw", - "jupyter-rfb>=0.4.1" # required so ImageWidget docs show up + "jupyter-rfb>=0.4.1", # required so ImageWidget docs show up "ipywidgets>=8.0.0,<9" ],