Skip to content

Commit db93f6f

Browse files
committed
Use datetime value to render datetime-local input_type
1 parent b39982b commit db93f6f

File tree

2 files changed

+20
-8
lines changed

2 files changed

+20
-8
lines changed

rest_framework/renderers.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -342,15 +342,12 @@ def render_field(self, field, parent_style):
342342
# Get a clone of the field with text-only value representation.
343343
field = field.as_form_field()
344344

345-
if style.get('input_type') == 'datetime-local' and isinstance(field.value, str):
345+
if style.get('input_type') == 'datetime-local':
346346
# The format of an input type="datetime-local" is "yyyy-MM-ddThh:mm"
347347
# followed by optional ":ss" or ":ss.SSS", so keep only the first three
348348
# digits of milliseconds to avoid browser console error.
349-
datetime_parts = field.value.split(".")
350-
if len(datetime_parts) > 1:
351-
field.value = f"{datetime_parts[0]}.{datetime_parts[1][:3]}"
352-
else:
353-
field.value = field.value.rstrip('Z')
349+
datetime_value = field._field.parent.validated_data.get(field.field_name)
350+
field.value = datetime_value.replace(tzinfo=None).isoformat(timespec="milliseconds").rstrip('Z')
354351

355352
if 'template' in style:
356353
template_name = style['template']

tests/test_renderers.py

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -517,7 +517,7 @@ class TestSerializer(serializers.Serializer):
517517
field = serializer['appointment']
518518
rendered = renderer.render_field(field, {})
519519
self.assertInHTML(
520-
'<input name="appointment" class="form-control" type="datetime-local" value="2024-12-24T00:55:30">',
520+
'<input name="appointment" class="form-control" type="datetime-local" value="2024-12-24T00:55:30.000">',
521521
rendered
522522
)
523523

@@ -532,7 +532,22 @@ class TestSerializer(serializers.Serializer):
532532
field = serializer['appointment']
533533
rendered = renderer.render_field(field, {})
534534
self.assertInHTML(
535-
'<input name="appointment" class="form-control" type="datetime-local" value="2024-12-24T00:55:00">',
535+
'<input name="appointment" class="form-control" type="datetime-local" value="2024-12-24T00:55:00.000">',
536+
rendered
537+
)
538+
539+
def test_datetime_field_rendering_with_format(self):
540+
class TestSerializer(serializers.Serializer):
541+
appointment = serializers.DateTimeField(format='%a %d %b %Y, %I:%M%p')
542+
543+
appointment = datetime(2024, 12, 24, 0, 55, 30, 345678)
544+
serializer = TestSerializer(data={"appointment": appointment})
545+
serializer.is_valid()
546+
renderer = HTMLFormRenderer()
547+
field = serializer['appointment']
548+
rendered = renderer.render_field(field, {})
549+
self.assertInHTML(
550+
'<input name="appointment" class="form-control" type="datetime-local" value="2024-12-24T00:55:30.345">',
536551
rendered
537552
)
538553

0 commit comments

Comments
 (0)