feat: Implement GEORADIUS_RO command #5678
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the GEORADIUS_RO redis command which is a read-only variant of the existing GEORADIUS command. Signed-off-by: Eric <hayter.eric@gmail.com>
|
Not sure what additional tests would make sense here, since this command is essentially a strict subset of |
Since the main functionality of the command has already been tested in the existing GEORADIUS tests, only smaller tests were added to ensure that all arguments associated with the store/write operations of GEORADIUS command are invalid. Signed-off-by: Eric <hayter.eric@gmail.com>
dranikpg
reviewed
Aug 16, 2025
src/server/geo_family.cc
Outdated
Comment on lines
790
to
799
| Type type; | ||
| if (read_only) { | ||
| type = | ||
| parser.MapNext("ASC", Type::ASC, "DESC", Type::DESC, "COUNT", Type::COUNT, "WITHCOORD", | ||
| Type::WITHCOORD, "WITHDIST", Type::WITHDIST, "WITHHASH", Type::WITHHASH); | ||
| } else { | ||
| type = parser.MapNext("STORE", Type::STORE, "STOREDIST", Type::STOREDIST, "ASC", Type::ASC, | ||
| "DESC", Type::DESC, "COUNT", Type::COUNT, "WITHCOORD", Type::WITHCOORD, | ||
| "WITHDIST", Type::WITHDIST, "WITHHASH", Type::WITHHASH); | ||
| } |
There was a problem hiding this comment.
You can use TryMapNext to avoid duplicating options. First try to parse RO option, if it's nullopt && you're not in RO, then you can try with the mutable options
Updated logic in parsing of arguments such that arguments for RO variants are not duplicated with the write version Signed-off-by: Eric <hayter.eric@gmail.com>
BorysTheDev
reviewed
Aug 19, 2025
Comment on lines
+306
to
+312
| // GEORADIUS_RO should not accept arguments for storing (writing data) | ||
| auto resp = | ||
| Run({"GEORADIUS_RO", "Europe", "13.4050", "52.5200", "900", "KM", "STORE_DIST", "store_key"}); | ||
| EXPECT_THAT(resp, ErrArg("syntax error")); | ||
|
|
||
| resp = Run({"GEORADIUS_RO", "Europe", "13.4050", "52.5200", "900", "KM", "STORE", "store_key"}); | ||
| EXPECT_THAT(resp, ErrArg("syntax error")); |
There was a problem hiding this comment.
Please add one successful usage of GEORADIUS_RO, to see that it works; you don't need to write all use cases
BorysTheDev
reviewed
Aug 19, 2025
Comment on lines
+297
to
+298
| // functionality for main GEORADIUS is already tested in the above function ensure that invalid | ||
| // arguments are not accepted |
There was a problem hiding this comment.
please remove this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the
GEORADIUS_ROcommand which is a read-only variant of the existingGEORADIUScommand. Resolves #3882.Command documentation can be found here.