Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: dotnet/aspnetcore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: pr-63231
Choose a head ref
  • 9 commits
  • 33 files changed
  • 3 contributors

Commits on Aug 14, 2025

  1. Add support for type-level validation attributes, update validation o… 

    …rdering
    @oroztocil
    oroztocil committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    48cf20a View commit details
    Browse the repository at this point in the history

  2. Code review fix, test fix

    @oroztocil
    oroztocil committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    e38ed29 View commit details
    Browse the repository at this point in the history

  3. Fix trimming annotation

    @oroztocil
    oroztocil committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    2252f23 View commit details
    Browse the repository at this point in the history

  4. Fix trimming annotation

    @oroztocil
    oroztocil committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    2d5d9c2 View commit details
    Browse the repository at this point in the history

  5. Separate caches for property and type attributes

    @oroztocil
    oroztocil committed Aug 14, 2025
    Configuration menu
    Copy the full SHA
    ea13cf1 View commit details
    Browse the repository at this point in the history

  6. Fix typo 

    Co-authored-by: Brennan <brecon@microsoft.com>
    @oroztocil @BrennanConroy
    oroztocil and BrennanConroy authored Aug 14, 2025
    Configuration menu
    Copy the full SHA
    124d213 View commit details
    Browse the repository at this point in the history

  7. Fix typo 

    Co-authored-by: Brennan <brecon@microsoft.com>
    @oroztocil @BrennanConroy
    oroztocil and BrennanConroy authored Aug 14, 2025
    Configuration menu
    Copy the full SHA
    31a1691 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2025

  1. Fix and simplify the emitted code

    @oroztocil
    oroztocil committed Aug 15, 2025
    Configuration menu
    Copy the full SHA
    be875c3 View commit details
    Browse the repository at this point in the history

  2. Add polymorphic validation attribute tests for derived types 

    - Added BasePolymorphicType and DerivedPolymorphicType classes to test inheritance scenarios
- BasePolymorphicType has SumLimit validation attribute (X + Y > 20)
- DerivedPolymorphicType has ProductLimit validation attribute (X * Y * Z > 100)
- Added PolymorphicProperty to ComplexType to test polymorphic validation
- Added 4 new test scenarios:
  1. ValidPolymorphicClassAttributeCheck_DoesNotProduceError - Tests valid values for both validations
  2. InvalidPolymorphicBaseClassAttributeCheck_ProducesError - Tests only base class validation failure
  3. InvalidPolymorphicDerivedClassAttributeCheck_ProducesError - Tests only derived class validation failure
  4. InvalidPolymorphicBothClassAttributesCheck_ProducesError - Tests both validations failing

This ensures that validation attributes on derived types work correctly in polymorphic scenarios.
    @captainsafia
    captainsafia committed Aug 15, 2025
    Configuration menu
    Copy the full SHA
    437dca6 View commit details
    Browse the repository at this point in the history
Loading