-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
tests: robustify system symbol overrides #17865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
c66e0ac
to
7ddbf80
Compare
7d74ea5
to
3a5a9f6
Compare
29ad8a3
to
7e1577b
Compare
7e1577b
to
e301c93
Compare
memdebug.h
includes
Before the override refactor (3bb5e58), overrides were never reset in tests,. After the refactor, tests do reset overrides in an accidental way: In such case a per-source Dedicing which is happening for an individual source is non-trivial. So we'd want to keep including But that still doesn't solve the accidental reset behavior. To make But, but, if we disable this feature in |
Follow-up to 3bb5e58 #17827
memdebug.h
should be included last, but for tests this wasnot done like that since the introduction of bundle builds. It
hasn't caused an issue in practice. Let's de-duplicate
memdebug.h
includes to make this exception more visible.
In case it causes problem in the future, the way to fix is to undef
(via
curl_mem_undef.h
merged in #17827) redefinitions beforeincluding per-source headers that include a system header that's
sensitive to those redefinitions. This happens rarely in test code.
potential redefinitions issues in tests that include system headers:
lib571, lib1960, tool1621, unit1305, unit1663, unit1664, unit2600