Issue #17223: implementation of Indentation TextBlockGoogleStyleFormattingCheck #17395
Conversation
|
XpathRegression..Tests only support one error per test. but this Check always logs two violations because #17284 (comment) |
|
We're duplicating much code here. Ideally, the whole check should be part of a single PR, so indentation functionality should be implemented in the original PR. But if you want, you can test indentation in this PR and then copy the commit to the main PR once it's basic functionality ( main PR's basic functionality ) is implemented. |
| final String[] expectedViolation = { | ||
| "7:14: " + getCheckMessage(CLASS, | ||
| TextBlockGoogleStyleFormattingCheck.MSG_CLOSE_QUOTES_ERROR), | ||
| }; |
There was a problem hiding this comment.
Just add the required violation msg here to pass the test. Violation is correct because quotes aren't aligned properly.
There was a problem hiding this comment.
But if you want, you can test indentation in this PR
yes, this pr is for testing mainly.
There was a problem hiding this comment.
Just add the required violation msg here to pass the test
that's the problem. not possible. multiple violations are not supported in Xpath... tests.
but we need the Check to give two violations #17284 (comment)
There was a problem hiding this comment.
@romani can you tell why multiple violations are not supported in XPath tests?
There was a problem hiding this comment.
there might be limitation created at the begining in code to simplify initial implementation.
but if we see how to add support of it, lets update to allow it.
There was a problem hiding this comment.
can we make Input file that has single violation ?
if not , let me know.
part of #17223
Added indentation feature to check if quotes are vertically aligned.
test only PR. NOT TO BE MERGED