Skip to content

Proper/Repack duplicate profile switch not working as expected #2017

@ObjectiveCesar

Description

@ObjectiveCesar

Version
1.60.0

Describe the bug
Let's say I have two separate releases of the same TV show episode:
My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX
My TV Show S12E06 1080p WEB H264-SuccessfulCrab

As you can see, the differences in both releases are the source (WEB-DL vs. WEB) and the group (FLUX vs. SuccessfulCrab).
I want only the first of those releases to be downloaded. So I set the a duplicate profile for the filter with the Title, Season and Episode active, so that those three criteria MUST match for the later release to be considered a duplicate.
But, I also want any Proper or Repack release to be downloaded, and not to be considered a duplicate. So I add the Proper and Repack criteria to my duplicate profile.
So basically My TV Show S12E06 1080p WEB H264-SuccessfulCrab would be considered a duplicate of My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX while My TV Show S12E06 REPACK 1080p AMZN WEB-DL DDP2 0 H 264-FLUX or ``My TV Show S12E06 PROPER 1080p WEB H264-SuccessfulCrab` would not.

But My TV Show S12E06 1080p WEB H264-SuccessfulCrab is only considered a duplicate of My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX when the Proper and Repack options in the duplicate profile are disabled. Naturally My TV Show S12E06 REPACK 1080p AMZN WEB-DL DDP2 0 H 264-FLUX and My TV Show S12E06 PROPER 1080p WEB H264-SuccessfulCrab are both then considered duplicates of My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX.

My evaluation led me to conclude that the Proper and/or Repack options in the duplicate profile will My TV Show S12E06 1080p WEB H264-SuccessfulCrab be considered NO duplicate of My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX because of the difference in their sources (WEB-DL vs WEB) although the duplicate filter states that source should not be a criteria for the duplicate check.

To Reproduce
Steps to reproduce the behavior:

  1. Use the mock server setup to reproduce.
  2. Create a filter for My TV Show, set season/episode filter, adding the test action, and using the pre-defined TV duplicate profile.
  3. Send My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX announcement and then My TV Show S12E06 1080p WEB H264-SuccessfulCrab.
  4. Only the first release will be added, the second one will be considered a duplicate. (this is expected)
  5. Send My TV Show S12E06 PROPER 1080p WEB H264-SuccessfulCrab announcement.
  6. It will also be considered a duplicate. (this is expected)
  7. Change the TV duplicate profile in Settings -> Releases -> TV -> Edit, activate Proper and Repack switches, and Save.
  8. Delete complete release history.
  9. Send My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX announcement and then My TV Show S12E06 1080p WEB H264-SuccessfulCrab
  10. Both releases are added because My TV Show S12E06 1080p WEB H264-SuccessfulCrab is NOT considered a duplicate of My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX.

Expected behavior
My TV Show S12E06 1080p WEB H264-SuccessfulCrab would be considered a duplicate of My TV Show S12E06 1080p AMZN WEB-DL DDP2 0 H 264-FLUX while My TV Show S12E06 REPACK 1080p AMZN WEB-DL DDP2 0 H 264-FLUX or My TV Show S12E06 PROPER 1080p WEB H264-SuccessfulCrab would not.

Screenshots

Image Image Image Image Image Image

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Chrome
  • Version: 134.0.6998.166

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions