-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add new plugin sse to support Server-Sent Events (SSE) #12498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
billmoling
wants to merge
13
commits into
apache:master
Choose a base branch
from
billmoling:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix the errors reported by CI. |
update the comments
I fixed the issue from last build. could you please approve another CI build? |
@billmoling There are still some issues with the tests. You can try testing locally. I'm used to checking these below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
This PR introduces a new
sse
plugin for Apache APISIX that enables support for Server-Sent Events (SSE), a mechanism for servers to push updates to the browser over a long-lived HTTP connection.SSE requires specific proxy settings and headers to ensure streaming behavior works reliably, which are not enabled by default in APISIX. This plugin configures those behaviors for routes or services that serve SSE.
Features
proxy_read_timeout
to prevent SSE connections from being cut off.Content-Type: text/event-stream; charset=utf-8
Cache-Control
Connection
X-Accel-Buffering
proxy_read_timeout
,cache_control
, andconnection_header
.Content-Type
header (enabled by default).Which issue(s) this PR fixes:
Fixes #10030 #10204
Checklist