Implement fan out request in the new mail API #2100
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2100 +/- ##
==========================================
+ Coverage 72.72% 72.82% +0.09%
==========================================
Files 634 635 +1
Lines 30365 30477 +112
Branches 3279 3285 +6
==========================================
+ Hits 22084 22194 +110
- Misses 6380 6385 +5
+ Partials 1901 1898 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements a fan-out request feature for the CAF (C++ Actor Framework) mail API, allowing actors to send concurrent requests to multiple destinations and collect their responses according to different selection policies (select_all or select_any).
- Adds
event_based_fan_out_response_handleclass to manage responses from multiple actors - Implements
fan_out_request()method in the mail API with configurable selection policies - Provides comprehensive test coverage for both result-returning and void functions with different policies
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libcaf_core/caf/fwd.hpp | Adds forward declaration for the new fan-out response handle template |
| libcaf_core/caf/event_based_response_handle.hpp | Removes unused helper structs that were likely moved elsewhere |
| libcaf_core/caf/event_based_mail.test.cpp | Adds extensive test cases for fan-out requests with different policies and scenarios |
| libcaf_core/caf/event_based_mail.hpp | Implements the fan_out_request() method with policy-based response aggregation |
| libcaf_core/caf/event_based_fan_out_response_handle.hpp | Complete implementation of the fan-out response handle with policy support |
| libcaf_core/caf/abstract_scheduled_actor.hpp | Adds friend declaration for the new fan-out response handle class |
Comments suppressed due to low confidence (5)
libcaf_core/caf/event_based_fan_out_response_handle.hpp:27
- The namespace 'detail1' is unclear and inconsistent with the existing 'detail' namespace used elsewhere in the codebase. Consider using 'detail::fan_out' or merging with the existing 'detail' namespace.
namespace caf::detail1 {
libcaf_core/caf/event_based_fan_out_response_handle.hpp:108
- The struct name 'select_select_all_helper' has a redundant 'select' prefix. Consider renaming to 'select_all_helper_selector' or similar.
struct select_select_all_helper;
libcaf_core/caf/event_based_mail.test.cpp:689
- Large block of commented-out test code (lines 689-772) should either be implemented, removed, or converted to a proper TODO with explanation of why it's disabled.
// TEST("send fan_out_request messages that return a composite result") {
97b8acb to
a5af0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP