Replies: 2 comments
-
@tagliala thanks for sharing this. This is an area that I don't know much about. With what you linked, my objective there was to rely on the defaults from ransack. I can see how this could be a leftover from that. I don't recall if I noticed this then or not. I'm open to either approach, even us declaring our own locale for this if you think it will help and offer improvements. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Addressed via #8714 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
activeadmin/lib/active_admin/filters/active_filter.rb
Lines 40 to 44 in a9f6751
activeadmin/lib/active_admin/filters/active_filter.rb
Lines 81 to 83 in a9f6751
https://github.com/activerecord-hackery/ransack/blob/9c66f49fc1be1a570d7b5ff1768b0bbc4a4f4524/lib/ransack/translate.rb#L14-L16
This can be:
active_admin.ransack
, and fallback on the original translation@javierjulio I have a working implementation of the latter at 3e11e2c, but I'm not sure that this is the correct direction
If we don't want this complexity, I would rather delegate everything to
Ransack
and simplify the codeBeta Was this translation helpful? Give feedback.
All reactions