Replies: 4 comments 15 replies
-
|
AFAICT there is no built-in way at the moment, leaving only questionable options: monkey patchingImportmap::ImportmapTagsHelper.prepend(Module.new do
def javascript_importmap_tags(entry_point, ...)
return super unless entry_point.to_s == 'active_admin'
safe_join([super, YOUR_JS], "\n")
end
end)overriding the views
|
Beta Was this translation helpful? Give feedback.
-
suggesting to modify generated views might put pressure on the gem to not touch them again, because if they ever do change in a functional way, a lot of people will spend a lot of time on understanding what went wrong. having programmatic hooks in a few places would seem cleaner to me, personally, as that would allow for deprecations, enforced migration, etc. |
Beta Was this translation helpful? Give feedback.
-
|
Not at all. We've made changes to call out "template changes" in our releases for that reason. We will avoid breaking changes on the Ruby side but templates can change and will be improved. We have #8337 up next as an example of that. The reason for templates is it makes it easier to maintain the library. We get auto loading now too when working on the library locally. Should make it easier for others to contribute and make changes in their apps. Also helps avoid monkey patching view components which was common and reduces the Arbre builder method list so you can create your own components without conflicts. |
Beta Was this translation helpful? Give feedback.
-
|
congratulations on the autoloading! i know what a big pain point that used to be. maybe having some empty partials and rendering them in some places would suffice to give "hook" capabilities. e.g. there could be an empty |
Beta Was this translation helpful? Give feedback.
-
I'm in favor of adding an empty partial for this use case |
Beta Was this translation helpful? Give feedback.
-
|
Sorry guys, I'm not in favor of this. Ordering can matter in the html_head for some so I prefer a simpler option of only one file that a dev can customize rather than multiple. The contents of the html_head partial is not expected to change. |
Beta Was this translation helpful? Give feedback.
-
|
@javierjulio Can we add some documentation on adding custom Javascript using the active admin importmap? The documentation on the web about how to do this with a rails engine is somewhat lacking. Currently I'm doing this (which isn't the right way I'm sure). What I really want to do is:
This seems like it should be doable but as I say, documentation around import camps in general is quite hard to come by. I would be happy to add a PR for documentation if I knew the "right" way to do this. Cheers |
Beta Was this translation helpful? Give feedback.
-
|
@javierjulio Could you please document how to add custom JS in https://github.com/activeadmin/activeadmin/blob/master/UPGRADING.md?
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the solution @barnaclebarnes, I also had to disable turbo in ActiveAdmin to make sure everything was working correctly. In case any one else also has this issue. |
Beta Was this translation helpful? Give feedback.
-
|
@javierjulio How do you use v4 without |
Beta Was this translation helpful? Give feedback.
-
|
@thisismydesign did you figure that one out? |
Beta Was this translation helpful? Give feedback.
-
|
@nathan-appere No. |
Beta Was this translation helpful? Give feedback.
-
|
At this point using importmap has no benefits compared to bundling |
Beta Was this translation helpful? Give feedback.
-
|
Noted elsewhere but importmap-rails is not required. If you prefer the bundling approach (e.g. jsbundling-rails) then go for it. I think most of us on the team prefer that anyway. It should work fine. If you have issues, let us know. Thank you. |
Beta Was this translation helpful? Give feedback.
-
|
I solved it like this: https://stackoverflow.com/questions/78985376/activeadmin-v4-how-to-add-custom-js-via-importmaps/78985377 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
I'm trying to add custom javascript, such as is needed for this addon
https://github.com/blocknotes/activeadmin_quill_editor
How do I do it? I've tried creating an
active_admin.jsbut it is not being loaded.Beta Was this translation helpful? Give feedback.
All reactions