Skip to content

[WIP] Bump ubuntu version to 24.04. #5574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Conversation

kounelisagis
Copy link
Member

Bump ubuntu version to 24.04


TYPE: BUILD
DESC: Bump ubuntu version to 24.04.

Comment on lines 5 to 8
env:
CXX: g++-10
CC: gcc-10
CXX: g++-13
CC: gcc-13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is GCC 13 the default compiler now?

Suggested change
env:
CXX: g++-10
CC: gcc-10
CXX: g++-13
CC: gcc-13

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is (ref).

Comment on lines +45 to +46
matrix_compiler_cc: 'gcc-13'
matrix_compiler_cxx: 'g++-13'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
matrix_compiler_cc: 'gcc-13'
matrix_compiler_cxx: 'g++-13'

Comment on lines +95 to +96
matrix_compiler_cc: 'gcc-13'
matrix_compiler_cxx: 'g++-13'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
matrix_compiler_cc: 'gcc-13'
matrix_compiler_cxx: 'g++-13'

@teo-tsirpanis
Copy link
Member

CI failure looks like a false positive, but ASAN isn't supposed to have false positives. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants