Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TheThingsNetwork/arduino-device-lib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: TheThingsNetwork/arduino-device-lib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feature/prevent-inf-loop
Choose a head ref
  • 8 commits
  • 2 files changed
  • 3 contributors

Commits on Jun 22, 2017

  1. Add infinite loop protection to readLine function. 

    Times out after 10 seconds now.
    @jpmeijers @johanstokking
    jpmeijers authored and johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    8727a3e View commit details
    Browse the repository at this point in the history

  2. Print error message if communication with RN2483 is unsuccessful.

    @jpmeijers @johanstokking
    jpmeijers authored and johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    f9ca19d View commit details
    Browse the repository at this point in the history

  3. Update TheThingsNetwork.cpp 

    Remove waitForOk to prevent a merge conflict
    @jpmeijers @johanstokking
    jpmeijers authored and johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    87c7d87 View commit details
    Browse the repository at this point in the history

  4. Remove comments, add spaces

    @jpmeijers @johanstokking
    jpmeijers authored and johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    1b496c7 View commit details
    Browse the repository at this point in the history

  5. Update TheThingsNetwork.cpp

    @jpmeijers @johanstokking
    jpmeijers authored and johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    18f7fd4 View commit details
    Browse the repository at this point in the history

  6. Make readLine timeout configurable.

    @jpmeijers @johanstokking
    jpmeijers authored and johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    5eef81f View commit details
    Browse the repository at this point in the history

  7. Fixed spacing

    @johanstokking
    johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    21e5e62 View commit details
    Browse the repository at this point in the history

  8. Timeout is about time, not about attempts

    @johanstokking
    johanstokking committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    952e413 View commit details
    Browse the repository at this point in the history
Loading