) => {
- return (
-
- {!!(collection.length) &&
}
-
- )
- }
- `,
- },
- ],
- },
- ],
- },
- {
- code: `
- const Component = (test: number, count: number, collection) => {
- return (
-
- {(test || (count)) &&
}
-
- )
- }
- `,
- errors: [
- {
- line: 5,
- column: 17,
- endLine: 5,
- endColumn: 21,
- suggestions: [
- {
- output: `
- const Component = (test: number, count: number, collection) => {
- return (
-
- {(!!(test) || (count)) &&
}
-
- )
- }
- `,
- },
- ],
- },
- {
- line: 5,
- column: 26,
- endLine: 5,
- endColumn: 31,
- suggestions: [
- {
- output: `
- const Component = (test: number, count: number, collection) => {
- return (
-
- {(test || !!(count)) &&
}
-
- )
- }
- `,
- },
- ],
- },
- ],
- },
- {
- code: `
- import react from 'react-native';
- const Component = (collection) => {
- let test = '';
- return (
-
- {test &&
}
-
- )
- }
- `,
- errors: 1,
- },
- {
- code: `
- const react = require('react-native');
- const Component = (collection) => {
- let test = '';
- return (
-
- {test &&
}
-
- )
- }
- `,
- errors: 1,
- },
- ],
-});
-
-ruleTesterJs.run('', rule, {
- valid: [
- {
- code: `
- const Component = (collection) => {
- const count = 0;
- return (
-
- {count &&
/*OK, no type information available*/ }
-
- )
- }
- `,
- },
- ],
- invalid: [],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-max-lines-per-function.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-max-lines-per-function.test.ts
deleted file mode 100644
index e1288d56619..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-max-lines-per-function.test.ts
+++ /dev/null
@@ -1,167 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sonar-max-lines-per-function';
-
-const ruleTester = new RuleTester({
- parserOptions: { ecmaVersion: 2018, ecmaFeatures: { jsx: true } },
-});
-
-ruleTester.run('Too many lines in functions', rule, {
- valid: [
- {
- code: `function f() {
- console.log("a");
- }`,
- options: [3],
- },
- {
- code: `function f() {
-
- console.log("a");
-
-
- }`,
- options: [3],
- },
- {
- code: `function f() {
- // comment
- console.log("a");
- /*
- multi
- line
- comment
- */
- }`,
- options: [3],
- },
- {
- code: `function foo() {
- console.log("a"); // End of line comment
- }`,
- options: [3],
- },
- {
- code: `
- console.log("a");
- function foo() {
- console.log("a");
- }
- console.log("a");
- `,
- options: [3],
- },
- {
- code: `function f() {
- function g() {
- console.log("a");
- }
- }`,
- options: [5],
- },
- {
- code: `(
-function
-()
-{
-}
-)
-()`, //IIFE are ignored
- options: [6],
- },
- {
- // React Function Component
- code: `
- function Welcome() {
- const greeting = 'Hello, world!';
-
- return {greeting}
- }`,
- options: [2],
- },
- {
- // React Function Component using function expressions and JSXFragments
- code: `
- let a = function Welcome() {
- const greeting = 'Hello, world!';
-
- return <>{greeting}
- }`,
- options: [2],
- },
- ],
- invalid: [
- {
- code: `function foo() {
- console.log("a");
- console.log("a");
- }`,
- options: [3],
- errors: [
- {
- message: `This function has 4 lines, which is greater than the 3 lines authorized. Split it into smaller functions.`,
- line: 1,
- endLine: 1,
- column: 10,
- endColumn: 13,
- },
- ],
- },
- {
- code: `function foo() {
- console.log("a");
- console.log("a");
- console.log("b");
- }`,
- options: [4],
- errors: [
- {
- message: `This function has 5 lines, which is greater than the 4 lines authorized. Split it into smaller functions.`,
- line: 1,
- endLine: 1,
- column: 10,
- endColumn: 13,
- },
- ],
- },
- {
- // React Function Component
- code: `
- function Welcome() {
- const greeting = 'Hello, world!';
-
- const doSomething = () => {
- console.log('foo');
- console.log('bar');
- console.log('baz');
- }
-
- return {greeting}
- }`,
- options: [2],
- errors: [
- {
- line: 5,
- },
- ],
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-max-lines.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-max-lines.test.ts
deleted file mode 100644
index ac4cfdb43cd..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-max-lines.test.ts
+++ /dev/null
@@ -1,59 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sonar-max-lines';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
-ruleTester.run('Too many lines in file', rule, {
- valid: [
- {
- code: `a;
- b;
- c;`,
- options: [3],
- },
- {
- code: `a;
-
- b;
- // comment
- c;`,
- options: [3],
- },
- ],
- invalid: [
- {
- code: `a;
- b;
-
- c;
- // comment
- d;`,
- options: [3],
- errors: [
- {
- message: `This file has 4 lines, which is greater than 3 authorized. Split it into smaller files.`,
- line: 0,
- column: 1,
- },
- ],
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-max-params.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-max-params.test.ts
deleted file mode 100644
index 14dd5e6f1a3..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-max-params.test.ts
+++ /dev/null
@@ -1,159 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { rule } from 'linting/eslint/rules/sonar-max-params';
-import { TypeScriptRuleTester } from '../../../tools';
-
-const MAX_PARAMS_3 = 3;
-const MAX_PARAMS_5 = 5;
-
-const ruleTester = new TypeScriptRuleTester();
-ruleTester.run(``, rule, {
- valid: [
- {
- code: `function f(a, b) {}`,
- options: [MAX_PARAMS_5],
- },
- {
- code: `function f(a, b, c, d, e) {}`,
- options: [MAX_PARAMS_5],
- },
- {
- code: `function f(a: any, b: any): any;`,
- options: [MAX_PARAMS_5],
- },
- {
- code: `function f(a: any, b: any, c: any, d: any, e: any): any;`,
- options: [MAX_PARAMS_5],
- },
- {
- code: `class C { m(a: any, b: any): any; }`,
- options: [MAX_PARAMS_5],
- },
- {
- code: `class C { constructor(private a: any, public b: any) {} }`,
- options: [MAX_PARAMS_5],
- },
- {
- code: `
- import { Component } from '@angular/core';
- @Component({/* ... */})
- class AppComponent {
- constructor(a, b, c, d, e, f) {}
- }
- `,
- options: [MAX_PARAMS_3],
- },
- ],
- invalid: [
- {
- code: `function f(a, b, c, d, e) {}`,
- options: [MAX_PARAMS_3],
- errors: [
- {
- message: "Function 'f' has too many parameters (5). Maximum allowed is 3.",
- line: 1,
- column: 1,
- endLine: 1,
- endColumn: 11,
- },
- ],
- },
- {
- code: `function f(a: any, b: any, c: any, d: any, e: any): any;`,
- options: [MAX_PARAMS_3],
- errors: [
- {
- message: "Function declaration 'f' has too many parameters (5). Maximum allowed is 3.",
- line: 1,
- column: 1,
- endLine: 1,
- endColumn: 11,
- },
- ],
- },
- {
- code: `class C { m(a: any, b: any, c: any, d: any, e: any): any; }`,
- options: [MAX_PARAMS_3],
- errors: [
- {
- message: "Empty function 'm' has too many parameters (5). Maximum allowed is 3.",
- line: 1,
- column: 11,
- endLine: 1,
- endColumn: 12,
- },
- ],
- },
- {
- code: `class C { constructor(a: any, b: any, c: any, d: any, e: any); }`,
- options: [MAX_PARAMS_3],
- errors: [
- {
- message:
- "Empty function 'constructor' has too many parameters (5). Maximum allowed is 3.",
- line: 1,
- column: 11,
- endLine: 1,
- endColumn: 22,
- },
- ],
- },
- {
- code: `class C { constructor(private a: any, b: any, c: any, d: any, e: any) {} }`,
- options: [MAX_PARAMS_3],
- errors: [
- {
- message: 'Constructor has too many parameters (5). Maximum allowed is 3.',
- line: 1,
- column: 11,
- endLine: 1,
- endColumn: 22,
- },
- ],
- },
- {
- code: `
- import { NotComponent } from '@angular/core';
- import { Component } from 'not-angular-core';
-
- @NotComponent({/* ... */})
- class C1 {
- constructor(a, b, c, d, e, f) {}
- }
-
- @Component({/* ... */})
- class C2 {
- constructor(a, b, c, d, e, f) {}
- }
-
- @DoesNotExist({/* ... */})
- class C3 {
- constructor(a, b, c, d, e, f) {}
- }
-
- class C4 {
- constructor(a, b, c, d, e, f) {}
- }
- `,
- options: [MAX_PARAMS_3],
- errors: 4,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-no-control-regex.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-no-control-regex.test.ts
deleted file mode 100644
index 779bbb8100c..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-no-control-regex.test.ts
+++ /dev/null
@@ -1,83 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sonar-no-control-regex';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-ruleTester.run('No control characters in regular expressions', rule, {
- valid: [
- {
- code: `/0/`,
- },
- {
- code: `/\\0/`,
- },
- {
- code: `/\\x20/`,
- },
- {
- code: `/\\u0020/`,
- },
- {
- code: `/\\u{001F}/`,
- },
- {
- code: `/\\cA/`,
- },
- ],
- invalid: [
- {
- code: `/\\x00/`,
- errors: [
- {
- message: 'Remove this control character: \\x00.',
- line: 1,
- endLine: 1,
- column: 2,
- endColumn: 6,
- },
- ],
- },
- {
- code: `/\\u001F/`,
- errors: [
- {
- message: 'Remove this control character: \\u001F.',
- line: 1,
- endLine: 1,
- column: 2,
- endColumn: 8,
- },
- ],
- },
- {
- code: `/\\u{001F}/u`,
- errors: [
- {
- message: 'Remove this control character: \\u{001F}.',
- line: 1,
- endLine: 1,
- column: 2,
- endColumn: 10,
- },
- ],
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-no-fallthrough.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-no-fallthrough.test.ts
deleted file mode 100644
index bc2341bac1d..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-no-fallthrough.test.ts
+++ /dev/null
@@ -1,352 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sonar-no-fallthrough';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
-ruleTester.run('No fallthrough in switch statement', rule, {
- valid: [
- {
- code: `
- switch (x) {
- case 0:
- process.exit(1);
- default:
- doSomething();
- }
- `,
- },
- {
- code: `
- switch (x) {
- case 0:
- if (foo()) {
- hello();
- process.exit(1);
- } else {
- there();
- process.exit(1);
- }
- default:
- doSomething();
- }
- `,
- },
- {
- code: `
- switch (x) {
- case 0:
- if (foo()) {
- hello();
- process.exit(1);
- } else {
- there();
- process.exit(1);
- }
- if (bar()) {
- console.log("unreachable");
- }
- default:
- doSomething();
- }
- `,
- },
- {
- code: `
- switch (param) {}
-
- // with not executable clause
- switch(x) {
- case a:
- break;
- case a:
- function f () {}
- }
-
- // with 0 case clauses
- switch(x) {
- default:
- foo();
- }
-
- // case with parentheses
- switch(x) {
- case (a):
- break;
- case (b):
- break;
- }
- `,
- },
- {
- code: `
- switch ( x ) {
- case 0:
- while ( isTrue() ) {
- doSomething();
- }
- /* falls through */
- default:
- console.log("hello");
- }
- `,
- },
- ],
- invalid: [
- {
- code: `
- function func(){
- while(condition) {
- switch (param) {
- case 0: // OK
- case 1: // OK
- break;
- case 2: // OK
- return;
- case 3: // OK
- throw new Error();
- case 4: // Noncompliant
- doSomething();
- case 5: // OK
- continue;
- default: // OK
- doSomethingElse();
- }
- }
- }`,
- errors: [
- {
- message:
- 'End this switch case with an unconditional break, continue, return or throw statement.',
- line: 12,
- column: 13,
- endLine: 12,
- endColumn: 17,
- },
- ],
- },
-
- {
- code: `
- switch (param) {
- default: // Noncompliant
- doSomething();
- case 0: // OK
- doSomethingElse();
- }`,
- errors: [{ line: 3 }],
- },
- {
- code: `
- function fun() {
- switch (param) {
- case 0: // OK
- doSomething(); break;
- case 1: // OK
- { break; }
- case 2: // Noncompliant
- { }
- case 3: // Noncompliant
- { doSomething(); }
- case 4: // OK
- { { return; } }
- case 5: // OK
- ;
- break;
- default: // OK
- doSomethingElse();
- }
- }
- `,
- errors: [{ line: 8 }, { line: 10 }],
- },
- {
- code: `
- function fun(){
- switch (param) {
- case a:
- break;
- case c:
- while(d) { doSomething(); }
- break;
- case g:
- break;
- case h || i:
- break;
- case g2:
- break;
- case j && k:
- break;
- case l ? m : n:
- break;
- case x: // Noncompliant
- if (f) {
- break;
- }
- case y: // OK
- if (condition) {
- return 0;
- } else {
- return 1;
- }
- default:
- doSomething();
- }
- }
- `,
- errors: [{ line: 19 }],
- },
- {
- code: `
- function fun() {
- switch (param) {
- case 0: // Noncompliant
- doSomethingElse();
- case 1:
- break;
- default:
- doSomething();
- }
- }
- `,
- errors: [{ line: 4 }],
- },
- {
- code: `
- function fun() {
- // OK with comment
- switch (x) {
- case 0:
- foo(); // fallthrough
-
- case 2:
- foo();
- // fall-through
-
- case 3:
- foo();
- // one more comment
- // fall through
-
- case 4:
- if (condition) {
- return foo();
- }
- /* falls through */
-
- case 5:
- foo();
- // passthrough because of this and that
-
- case 6:
- foo();
- // nobreak
-
- case 7:
- foo();
- // proceed
-
- case 8: // Noncompliant
- if (condition) {
- return foo();
- }
- case 9: // some comment
- case 10:
- bar();
- }
- }
- `,
- errors: [{ line: 35 }],
- },
- {
- code: `
- switch (x) {
- case 0:
- if (foo()) {
- process.exit(1);
- }
- default:
- doSomething();
- }
- `,
- errors: [{ line: 3 }],
- },
- {
- code: `
- switch (x) {
- case 0:
- if (foo()) {
- process.exit(1);
- }
- doSomething();
- default:
- doSomething();
- }
- `,
- errors: [{ line: 3 }],
- },
- {
- code: `
- process.exit(1);
- switch (x) {
- case 0:
- doSomething();
- default:
- doSomethingElse();
- }
- `,
- errors: [{ line: 4 }],
- },
- {
- code: `
- switch (x) {
- case 0:
- doSomething();
- ForEachRecord(target, function(options) {
- doSomethingElse();
- });
- break;
- case 1:
- doSomething();
- default:
- doSomethingElse();
- }
-
- `,
- errors: [{ line: 9 }],
- },
- {
- code: `
- function doSomething() {
- doSmth();
- }
- switch (x) {
- case 0:
- doSomething();
- case 1:
- doSomething();
- default:
- doSomethingElse();
- }
- `,
- errors: [{ line: 6 }, { line: 8 }],
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-no-invalid-regexp.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-no-invalid-regexp.test.ts
deleted file mode 100644
index 5d6ea264f71..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-no-invalid-regexp.test.ts
+++ /dev/null
@@ -1,89 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { TypeScriptRuleTester } from '../../../tools';
-import { rule } from 'linting/eslint/rules/sonar-no-invalid-regexp';
-
-const ruleTesterTs = new TypeScriptRuleTester();
-ruleTesterTs.run('Malformed regular expressions', rule, {
- valid: [
- {
- code: `new RegExp("\\\\(\\\\[");`,
- },
- {
- code: `new RegExp("\\\\(\\\\[", "g");`,
- },
- {
- code: `str.match("\\\\(\\\\[");`,
- },
- {
- code: `str.replace("([", "{");`,
- },
- {
- code: `'xxx'.match();`,
- },
- {
- code: `foo.match('[');`,
- },
- {
- code: `
- new RegExp();
- new RegExp('foo', 4);
- `,
- },
- ],
- invalid: [
- {
- code: `new RegExp("([");`,
- errors: [
- {
- message: 'Invalid regular expression: /([/: Unterminated character class',
- line: 1,
- column: 1,
- endLine: 1,
- endColumn: 17,
- },
- ],
- },
- {
- code: `'xxx'.match("([");`,
- errors: [
- {
- message: 'Invalid regular expression: /([/: Unterminated character class',
- line: 1,
- column: 1,
- endLine: 1,
- endColumn: 18,
- },
- ],
- },
- {
- code: `new RegExp("\\\\(\\\\[", "a");`,
- errors: [
- {
- message: "Invalid flags supplied to RegExp constructor 'a'",
- line: 1,
- column: 1,
- endLine: 1,
- endColumn: 26,
- },
- ],
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-no-misleading-character-class.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-no-misleading-character-class.test.ts
deleted file mode 100644
index b20111343ac..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-no-misleading-character-class.test.ts
+++ /dev/null
@@ -1,112 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sonar-no-misleading-character-class';
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-
-const combiningClass = c => `Move this Unicode combined character '${c}' outside of [...]`;
-
-ruleTester.run('', rule, {
- valid: [
- 'var r = /[\\uD83D\\d\\uDC4D]/',
- 'var r = /[\\uD83D-\\uDC4D]/',
- 'var r = /[👍]/u',
- 'var r = /[\\uD83D\\uDC4D]/u',
- 'var r = /[\\u{1F44D}]/u',
- 'var r = /❇️/',
- 'var r = /Á/',
- 'var r = /[❇]/',
- 'var r = /👶🏻/',
- 'var r = /[👶]/u',
- 'var r = /🇯🇵/',
- 'var r = /[JP]/',
- 'var r = /👨👩👦/',
-
- // Ignore solo lead/tail surrogate.
- 'var r = /[\\uD83D]/',
- 'var r = /[\\uDC4D]/',
- 'var r = /[\\uD83D]/u',
- 'var r = /[\\uDC4D]/u',
-
- // Ignore solo combining char.
- 'var r = /[\\u0301]/',
- 'var r = /[\\uFE0F]/',
- 'var r = /[\\u0301]/u',
- 'var r = /[\\uFE0F]/u',
-
- // Coverage
- 'var r = /[x\\S]/u',
- 'var r = /[xa-z]/u',
- ],
- invalid: [
- {
- code: 'var r = /[\\u0041\\u0301-\\u0301]/',
- errors: [{ column: 17, endColumn: 23, message: combiningClass('\\u0041\\u0301') }],
- },
- {
- code: 'var r = /[Á]/',
- errors: [{ message: combiningClass('Á') }],
- },
- {
- code: 'var r = /[Á]/u',
- errors: [{ message: combiningClass('Á') }],
- },
- {
- code: 'var r = /[\\u0041\\u0301]/',
- errors: [{ message: combiningClass('\\u0041\\u0301') }],
- },
- {
- code: 'var r = /[\\u0041\\u0301]/u',
- errors: [{ message: combiningClass('\\u0041\\u0301') }],
- },
- {
- code: 'var r = /[\\u{41}\\u{301}]/u',
- errors: [{ message: combiningClass('\\u{41}\\u{301}') }],
- },
- {
- code: 'var r = /[❇️]/',
- errors: [{ message: combiningClass('❇️') }],
- },
- {
- code: 'var r = /[❇️]/u',
- errors: [{ message: combiningClass('❇️') }],
- },
- {
- code: 'var r = /[\\u2747\\uFE0F]/',
- errors: [{ message: combiningClass('\\u2747\\uFE0F') }],
- },
- {
- code: 'var r = /[\\u2747\\uFE0F]/u',
- errors: [{ message: combiningClass('\\u2747\\uFE0F') }],
- },
- {
- code: 'var r = /[\\u{2747}\\u{FE0F}]/u',
- errors: [{ message: combiningClass('\\u{2747}\\u{FE0F}') }],
- },
- {
- code: String.raw`var r = new globalThis.RegExp("[❇️]", "")`,
- errors: [{ message: combiningClass('❇️') }],
- },
- {
- code: String.raw`"cc̈d̈d".replaceAll(RegExp("[c̈d̈]"), "X")`,
- errors: [{ message: combiningClass('c̈') }],
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-no-regex-spaces.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-no-regex-spaces.test.ts
deleted file mode 100644
index 4e20b174482..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-no-regex-spaces.test.ts
+++ /dev/null
@@ -1,85 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sonar-no-regex-spaces';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-ruleTester.run('Regex with multiple spaces', rule, {
- valid: [
- {
- code: `/ /`,
- },
- {
- code: `/ {2}/`,
- },
- {
- code: `/ a /`,
- },
- {
- // will be reported by S5869
- code: `/[ ]/`,
- },
- {
- code: `
- / ( )/;
- /a | b/;
- / .* /;
- / \\w /;
- / . /;
- / \\b /;`,
- },
- ],
- invalid: [
- {
- code: `/a b /`,
- errors: [
- {
- message: 'If multiple spaces are required here, use number quantifier ({3}).',
- line: 1,
- endLine: 1,
- column: 3,
- endColumn: 6,
- },
- ],
- },
- {
- code: `/ a /`,
- errors: 2,
- },
- {
- code: `/ */; / +/; / {2}/; / ?/ `,
- errors: 4,
- },
- {
- code: `/(a b)/ `,
- errors: 1,
- },
- {
- code: `
- / ( )/;
- /a | b/;
- / .* /;
- / \\w /;
- / . /;
- / \\b /;`,
- errors: 6,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sonar-no-unused-vars.test.ts b/eslint-bridge/tests/linting/eslint/rules/sonar-no-unused-vars.test.ts
deleted file mode 100644
index 9b4ba51edcf..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sonar-no-unused-vars.test.ts
+++ /dev/null
@@ -1,268 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sonar-no-unused-vars';
-
-const ruleTester = new RuleTester({
- parserOptions: { sourceType: 'module', ecmaVersion: 2018, ecmaFeatures: { jsx: true } },
-});
-
-ruleTester.run('Local variables should be used', rule, {
- valid: [
- {
- code: `
- var a = 0; // OK, global
- export let b = 0 // OK, global
-
- function fun() {
- function f1() { console.log("f1"); } // OK
- f1();
- }
-
- function bar(){
- try {
- } catch (e) { // OK
- }
-
- bar(function unusedFunctionExpression() {}); // OK, ignore function expression
- }
-
- function foo(){
- var x1 = 1, // OK
- y1 = -x1; // OK
- foo(y1);
- }
-
- function Person() {
- this.name = null;
-
- this.getName = function() { // OK
- return name;
- }
- }
-
- function used_in_template_string() {
- const foo = '.';
- return new RegExp(\`\${foo}\`);
- }
- `,
- },
- ],
- invalid: [
- {
- code: `
- function fun() {
- var a = 0; // Noncompliant
- var b = 1; // OK
- return b;
- }`,
- errors: [
- {
- message: `Remove the declaration of the unused 'a' variable.`,
- line: 3,
- endLine: 3,
- column: 13,
- endColumn: 14,
- },
- ],
- },
- {
- code: `
- function fun1() {
- var a = 0; // OK
- function nested() { // Noncompliant
- a = 1;
- }
- }
-
- function fun2() {
- var a = 0; // Noncompliant
- function nested(a) { // Noncompliant
- a = 1;
- }
- }
-
- function fun3() {
- let a = 0; // Noncompliant
- const b = 1; // Noncompliant
- let c // OK
- return c;
- }
-
- function* fun4() {
- var a = 0; // Noncompliant
- var b = 1; // OK
- return b;
- }`,
- errors: [
- {
- message: `Remove unused function 'nested'.`,
- line: 4,
- },
- {
- line: 10,
- },
- {
- line: 11,
- },
- {
- line: 17,
- },
- {
- line: 18,
- },
- {
- line: 24,
- },
- ],
- },
- {
- code: `
- function fun1() {
- var f1 = function() { console.log("f1"); } // Noncompliant
- }
-
- function fun2() {
- function f1() { console.log("f1"); } // Noncompliant
- }
-
- class C {
- f() {
- var a; // Noncompliant
- }
- }
-
- var f = (p) => {
- var x; // Noncompliant
- var y = p.y; // Noncompliant
- }
-
- var f = p => {
- var x; // Noncompliant
- }
-
- function foo(){
- var x = 1; // Noncompliant
- var x = 2; // Noncompliant
-
- class A {} // OK, ignore anything except variables and functions
- }
- `,
- errors: [
- {
- line: 3,
- },
- {
- line: 7,
- },
- {
- line: 12,
- },
- {
- line: 17,
- },
- {
- line: 18,
- },
- {
- line: 22,
- },
- {
- line: 26,
- },
- {
- line: 27,
- },
- ],
- },
- {
- code: `
- function objectDestructuringException(obj) {
- var {a, b, c, ...interestingProps} = obj; // OK
- foo(interestingProps);
-
- var {a1, b1, c1} = obj; // Noncompliant, b1
-
- foo(a1, c1);
-
- var {a2, b2, c2, ...interestingProps2} = obj; // Noncompliant, interestingProps2
-
-
- var {a3, b: b3, c3, ...interestingProps3} = obj; // Noncompliant, b3
-
- foo(interestingProps3);
-
- var {} = obj;
- }`,
- errors: [
- {
- message: `Remove the declaration of the unused 'b1' variable.`,
- line: 6,
- column: 18,
- },
- {
- message: `Remove the declaration of the unused 'interestingProps2' variable.`,
- line: 10,
- column: 29,
- },
- {
- message: `Remove the declaration of the unused 'b3' variable.`,
- line: 13,
- column: 21,
- },
- ],
- },
- {
- code: `
- const constUsed = "this is used";
- let letUsed = "this is used";
- var varUsed = "this is used";
- if(constUsed && letUsed && varUsed) {
- const constUsed = "unused"; // Noncompliant
- let letUsed = "unused"; // Noncompliant
- var varUsed = "used";
-
- function unusedFunc() { // Noncompliant
-
- }
- }`,
- errors: [{ line: 6 }, { line: 7 }, { line: 10 }],
- },
- {
- code: `
- function used_in_jsx(icon) {
- const UsedIcon = icon;
- const UnusedIcon = icon; // Noncompliant
- const lowerCased = icon;
- const tagContent = "content"
- const tagAttribute = "attribute";
-
- // even if React requires user-defined components to start from capital letter
- // let's test name starting from lower-cased letter
- ;
- return {tagContent};
- }
- `,
- errors: [
- { line: 4, message: `Remove the declaration of the unused \'UnusedIcon\' variable.` },
- ],
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/sql-queries.test.ts b/eslint-bridge/tests/linting/eslint/rules/sql-queries.test.ts
deleted file mode 100644
index 1a62be157e2..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/sql-queries.test.ts
+++ /dev/null
@@ -1,213 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/sql-queries';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-ruleTester.run('Formatting SQL queries is security-sensitive', rule, {
- valid: [
- {
- code: `
- const mysql = require('mysql');
- conn.query(sql, [userInput], (err, res) => {});
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- conn.query(sql, (err, res) => {});
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- conn.query(sql);
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- conn.query();
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- conn.query("SELECT * FROM FOO");
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- conn.query("SELECT *" + " FROM FOO" + " WHERE BAR");
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- conn.query(foo("SELECT *" + userInput));
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- conn.query(\`SELECT * FROM FOO\`);
- `,
- },
- {
- code: `
- const mysql = require('mysql');
- sql = "select from " + userInput;
- conn.query(sql);
- `,
- },
- {
- code: `
- const pg = require('pg');
- conn.query(sql);
- `,
- },
- {
- code: `
- const mysql2 = require('mysql2');
- conn.query(sql);
- `,
- },
- {
- code: `
- const sequelize = require('sequelize');
- conn.query(sql);
- `,
- },
- {
- code: `
- import { query } from 'myDB';
- conn.query("select from " + userInput);
- `,
- },
- {
- // FN, userId is not escaped
- code: `
- const mysql = require('mysql');
- conn.query("SELECT * FROM users WHERE id = ' + userId", [userInput], (err, res) => {});
- `,
- },
- {
- code: `
- require('mysql');
- conn.query(x.foo());`,
- },
- {
- code: `
- require('mysql');
- conn.query(foo());`,
- },
- {
- code: `
- require('mysql');
- conn.query(concat());`,
- },
- ],
- invalid: [
- {
- code: `
- const mysql = require('mysql');
- conn.query('SELECT * FROM users WHERE id = ' + userId, (err, res) => {});`,
- errors: [
- {
- message: 'Make sure that executing SQL queries is safe here.',
- line: 3,
- endLine: 3,
- column: 7,
- endColumn: 17,
- },
- ],
- },
- {
- code: `
- import { query } from 'pg';
- conn.query('SELECT * FROM users WHERE id = ' + userId, (err, res => {}));
- `,
- errors: 1,
- },
- {
- code: `
- import { query } from 'mysql2';
- conn.query('SELECT * FROM users WHERE id = ' + userId, (err, res => {}));
- `,
- errors: 1,
- },
- {
- code: `
- import { query } from 'sequelize';
- conn.query('SELECT * FROM users WHERE id = ' + userId, (err, res => {}));
- `,
- errors: 1,
- },
- // FP, parameters are escaped
- {
- code: `
- const mysql = require('mysql');
- conn.query('SELECT * FROM users WHERE id = ' + connection.escape(userId), (err, res => {}));
- `,
- errors: 1,
- },
-
- {
- code: `
- require('mysql');
- conn.query('a' + 'b' + x);`,
- errors: 1,
- },
- {
- code: `
- require('mysql');
- conn.query('a' + x + 'b');`,
- errors: 1,
- },
- {
- code: `
- require('mysql');
- conn.query(x + 'a' + 'b');`,
- errors: 1,
- },
-
- {
- code: `
- require('mysql');
- conn.query(\`a \${x} b\`);`,
- errors: 1,
- },
-
- {
- code: `
- require('mysql');
- conn.query(x.concat());`,
- errors: 1,
- },
-
- {
- code: `
- require('mysql');
- conn.query(x.replace());`,
- errors: 1,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/standard-input.test.ts b/eslint-bridge/tests/linting/eslint/rules/standard-input.test.ts
deleted file mode 100644
index 88625d7568e..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/standard-input.test.ts
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/standard-input';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
-ruleTester.run('Reading the Standard Input is security-sensitive', rule, {
- valid: [
- {
- code: `foo.bar`,
- },
- {
- code: `process.stdout`,
- },
- {
- code: `processFoo.stdin`,
- },
- {
- code: `'process.stdin'`,
- },
- ],
- invalid: [
- {
- code: `let x = process.stdin;`,
- errors: [
- {
- message: 'Make sure that reading the standard input is safe here.',
- line: 1,
- endLine: 1,
- column: 9,
- endColumn: 22,
- },
- ],
- },
- {
- code: `process.stdin.on('readable', () => {});`,
- errors: 1,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/stateful-regex.test.ts b/eslint-bridge/tests/linting/eslint/rules/stateful-regex.test.ts
deleted file mode 100644
index e72ab5db5a3..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/stateful-regex.test.ts
+++ /dev/null
@@ -1,243 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { rule } from 'linting/eslint/rules/stateful-regex';
-import { RuleTester } from 'eslint';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
-ruleTester.run('Regular expressions with the global flag should be used with caution', rule, {
- valid: [
- {
- code: `/none/;`,
- },
- {
- code: `/unicode/u;`,
- },
- {
- code: `/global/g;`,
- },
- {
- code: `RegExp('none');`,
- },
- {
- code: `RegExp('global', 'g');`,
- },
- {
- code: `new RegExp('global', 'g');`,
- },
- {
- code: `/sticky/y; `,
- },
- {
- code: `RegExp('sticky', 'y');`,
- },
- {
- code: `new RegExp('sticky', 'y');`,
- },
- {
- code: `while (condition) {/foo/g.exec(input);}`,
- },
- {
- code: `while (() => /foo/g.exec(input)) {}`,
- },
- {
- code: `const re = /foo/g; while (re.exec(input)) {}`,
- },
- {
- code: `while (exec(input)) {}`,
- },
- {
- code: `while (/foo/g.execute(input)) {}`,
- },
- {
- code: `while (/foo/u.exec(input)) {}`,
- },
- {
- code: `while (RegExp('foo').exec(input)) {}`,
- },
- {
- code: `
- const re = /foo/;
- re.test('foo');
- re.test('bar');
- `,
- },
- {
- code: `
- const re = /foo/;
- re.exec('foo');
- re.exec('bar');
- `,
- },
- {
- code: `
- const re = /foo/g;
- re.test('foo');
- `,
- },
- {
- code: `
- const re = /foo/g;
- re.exec('foo');
- `,
- },
- {
- code: `
- const re = /foo/g;
- re.test(input);
- re.test(input);
- `,
- },
- {
- code: `re.test(input);`,
- },
- {
- code: `
- const re = /foo/g;
- re.test(input1);
- re.lastIndex = 0;
- re.test(input2);
- `,
- },
- {
- code: `let re; re.lastIndex = 0;`,
- },
- {
- code: `re.lastIndex = 0;`,
- },
- {
- code: `foo = re.lastIndex;`,
- },
- {
- code: `
- const re = /foo/g;
- re.test('foo');
- re.test(''); // ok, empty string is used to reset the pattern
- re.test('bar');
-
- const re2 = /foo/g;
- re2.test('foo');
- re2.test(""); // ok, empty string is used to reset the pattern
- re2.test('bar');
- `,
- },
- ],
- invalid: [
- {
- code: `/globalsticky/gy;`,
- errors: [
- {
- message: JSON.stringify({
- message: `Remove the 'g' flag from this regex as it is shadowed by the 'y' flag.`,
- secondaryLocations: [],
- }),
- line: 1,
- endLine: 1,
- column: 1,
- endColumn: 17,
- },
- ],
- },
- {
- code: `RegExp('globalsticky', 'gy');`,
- errors: 1,
- },
- {
- code: `new RegExp('globalsticky', 'gy');`,
- errors: 1,
- },
- {
- code: `while (/foo/g.exec(input)) {}`,
- errors: [
- {
- message: JSON.stringify({
- message: `Extract this regular expression to avoid infinite loop.`,
- secondaryLocations: [],
- }),
- line: 1,
- endLine: 1,
- column: 8,
- endColumn: 14,
- },
- ],
- },
- {
- code: `do {} while (/foo/g.exec(input));`,
- errors: 1,
- },
- {
- code: `while ((/foo/g.exec(input)) !== null) {}`,
- errors: 1,
- },
- {
- code: `while (RegExp('foo', 'g').exec(input)) {}`,
- errors: 1,
- },
- {
- code: `while (new RegExp('foo', 'g').exec(input)) {}`,
- errors: 1,
- },
- {
- code: `
- const re = /foo/g;
- re.test('foo');
- re.test('bar');
- `,
- errors: [
- {
- message: JSON.stringify({
- message: `Remove the 'g' flag from this regex as it is used on different inputs.`,
- secondaryLocations: [
- { message: 'Usage 1', column: 8, line: 3, endColumn: 22, endLine: 3 },
- { message: 'Usage 2', column: 8, line: 4, endColumn: 22, endLine: 4 },
- ],
- }),
- line: 2,
- endLine: 2,
- column: 20,
- endColumn: 26,
- },
- ],
- },
- {
- code: `
- const re = RegExp('foo', 'g');
- re.test('foo');
- re.test('bar');
- `,
- errors: 1,
- },
- {
- code: `
- const re = new RegExp('foo', 'g');
- re.test('foo');
- re.test('bar');
- `,
- errors: 1,
- },
- {
- code: `
- const re = /foo/g;
- re.exec('foo');
- re.exec('bar');
- `,
- errors: 1,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/strict-transport-security.test.ts b/eslint-bridge/tests/linting/eslint/rules/strict-transport-security.test.ts
deleted file mode 100644
index bb3d2390cef..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/strict-transport-security.test.ts
+++ /dev/null
@@ -1,238 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { rule } from 'linting/eslint/rules/strict-transport-security';
-import { RuleTester } from 'eslint';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-ruleTester.run('Disabling Strict-Transport-Security policy is security-sensitive', rule, {
- valid: [
- {
- code: `
- const helmet = require('helmet')
- const express = require('express');
- const app = express();
- app.use(
- helmet()
- );`,
- },
- {
- code: `
- const helmet = require('helmet')
- const express = require('express');
- const app = express();
- app.use(
- helmet({
- hsts: true,
- })
- );`,
- },
- {
- code: `
- const helmet = require('helmet')
- const express = require('express');
- const app = express();
- app.use(
- helmet.hsts({})
- );`,
- },
- {
- code: `
- const helmet = require('helmet')
- const express = require('express');
- const app = express();
- app.use(
- helmet.hsts({
- maxAge: 31536000,
- })
- );`,
- },
- {
- code: `
- const helmet = require('helmet')
- const express = require('express');
- const app = express();
- app.use(
- helmet.hsts({
- maxAge: 31536000,
- includeSubDomains: true,
- })
- );`,
- },
- {
- code: `
- const hsts = require('hsts');
- const express = require('express');
- const app = express();
- app.use(
- hsts({})
- );`,
- },
- {
- code: `
- const hsts = require('hsts');
- const express = require('express');
- const app = express();
- app.use(
- hsts({
- maxAge: 31536000,
- })
- );`,
- },
- {
- code: `
- const hsts = require('hsts');
- const express = require('express');
- const app = express();
- app.use(
- hsts({
- maxAge: 31536000,
- includeSubDomains: true,
- })
- );`,
- },
- {
- code: `
- const hsts = require('hsts');
- const express = require('express');
- const app = express();
- app.use(
- hsts({
- maxAge: unknown,
- includeSubDomains: true,
- })
- );`,
- },
- {
- code: `
- const express = require('express');
- const app = express();
- app.use(
- whatever({
- maxAge: 31536000,
- includeSubDomains: true,
- })
- );`,
- },
- {
- code: `
- const express = require('express');
- const app = express();
- app.use(
- unknown.whatever({
- maxAge: 31536000,
- includeSubDomains: true,
- })
- );`,
- },
- ],
- invalid: [
- {
- code: `
- const helmet = require('helmet')
- const express = require('express');
- const app = express();
- app.use(
- helmet({
- hsts: false,
- })
- );`,
- errors: [
- {
- message: JSON.stringify({
- message: `Disabling Strict-Transport-Security policy is security-sensitive.`,
- secondaryLocations: [
- {
- column: 14,
- line: 7,
- endColumn: 25,
- endLine: 7,
- },
- ],
- }),
- line: 5,
- endLine: 9,
- column: 11,
- endColumn: 12,
- },
- ],
- },
- {
- code: `
- const helmet = require('helmet')
- const express = require('express');
- const app = express();
- app.use(
- helmet.hsts({
- maxAge: 3153600,
- includeSubDomains: false,
- })
- );`,
- errors: [
- {
- message: JSON.stringify({
- message: `Disabling Strict-Transport-Security policy is security-sensitive.`,
- secondaryLocations: [
- {
- column: 14,
- line: 7,
- endColumn: 29,
- endLine: 7,
- },
- ],
- }),
- line: 5,
- endLine: 10,
- column: 11,
- endColumn: 12,
- },
- {
- message: JSON.stringify({
- message: `Disabling Strict-Transport-Security policy is security-sensitive.`,
- secondaryLocations: [
- {
- column: 14,
- line: 8,
- endColumn: 38,
- endLine: 8,
- },
- ],
- }),
- line: 5,
- endLine: 10,
- column: 11,
- endColumn: 12,
- },
- ],
- },
- {
- code: `
- const hsts = require('hsts');
- const express = require('express');
- const app = express();
- app.use(
- hsts({
- maxAge: 3153600,
- includeSubDomains: false,
- })
- );`,
- errors: 2,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/strings-comparison.test.ts b/eslint-bridge/tests/linting/eslint/rules/strings-comparison.test.ts
deleted file mode 100644
index 98550d04a74..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/strings-comparison.test.ts
+++ /dev/null
@@ -1,116 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { rule } from 'linting/eslint/rules/strings-comparison';
-import { RuleTester } from 'eslint';
-import { TypeScriptRuleTester } from '../../../tools';
-
-const ruleTesterJs = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-ruleTesterJs.run('Comparison operators should not be used with strings [js]', rule, {
- valid: [
- {
- code: `
- let str1 = 'hello', str2 = 'world';
- str1 < str2; // not reported without type information`,
- },
- ],
- invalid: [],
-});
-
-const ruleTesterTs = new TypeScriptRuleTester();
-ruleTesterTs.run(`Comparison operators should not be used with strings [ts]`, rule, {
- valid: [
- {
- code: `
- let str1 = 'hello', str2 = 'world';
- str1 == str2;`,
- },
- {
- code: `
- let str = 'hello', num = 5;
- str < num;`,
- },
- {
- code: `
- let str = 'hello', num = 5;
- num < str;`,
- },
- {
- code: `
- let str = 'hello';
- str < 'h';`,
- },
- {
- code: `
- let str = 'hello';
- 'h' < str;`,
- },
- {
- code: `
- ['foo', 'bar', 'baz'].sort((a, b) => a < b);
- `,
- },
- {
- code: `
- sort((a: string, b: string) => a < b)
- `,
- },
- ],
- invalid: [
- {
- code: `
- let str1 = 'hello', str2 = 'world';
- str1 < str2;`,
- errors: [
- {
- message:
- '{"message":"Convert operands of this use of \\"<\\" to number type.","secondaryLocations":[{"column":8,"line":3,"endColumn":12,"endLine":3},{"column":15,"line":3,"endColumn":19,"endLine":3}]}',
- line: 3,
- column: 14,
- endLine: 3,
- endColumn: 15,
- },
- ],
- },
- {
- code: `
- let str1 = 'hello', str2 = 'world';
- str1 <= str2;`,
- errors: 1,
- },
- {
- code: `
- let str1 = 'hello', str2 = 'world';
- str1 > str2;`,
- errors: 1,
- },
- {
- code: `
- let str1 = 'hello', str2 = 'world';
- str1 >= str2;`,
- errors: 1,
- },
- {
- code: `
- (function () {})((a: string, b: string) => a < b)
- `,
- errors: 1,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/super-invocation.test.ts b/eslint-bridge/tests/linting/eslint/rules/super-invocation.test.ts
deleted file mode 100644
index fea4a0b0c88..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/super-invocation.test.ts
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { rule } from 'linting/eslint/rules/super-invocation';
-import { RuleTester } from 'eslint';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-ruleTester.run('"super()" should be invoked appropriately', rule, {
- valid: [
- {
- code: `
- var B1b = class extends A1 {
- constructor() {
- super(); // OK
- super.x = 1;
- }
- }
- `,
- },
- ],
- invalid: [
- {
- code: `class A extends B { constructor() {this.bar();}}`,
- errors: 2,
- },
- {
- code: `class A extends B { constructor(a) { while (a) super(); } }`,
- errors: 2,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/switch-without-default.test.ts b/eslint-bridge/tests/linting/eslint/rules/switch-without-default.test.ts
deleted file mode 100644
index 62488a2e6ae..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/switch-without-default.test.ts
+++ /dev/null
@@ -1,60 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { rule } from 'linting/eslint/rules/switch-without-default';
-import { RuleTester } from 'eslint';
-import { TypeScriptRuleTester } from '../../../tools';
-
-const tests = {
- valid: [
- {
- code: `
- switch (param) {
- case 0:
- break;
- default:
- break;
- }`,
- },
- ],
- invalid: [
- {
- code: `
- switch (param) {
- case 0:
- break;
- }`,
- errors: [
- {
- message: `Add a "default" clause to this "switch" statement.`,
- line: 2,
- endLine: 2,
- column: 9,
- endColumn: 15,
- },
- ],
- },
- ],
-};
-
-const ruleTesterJs = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
-const ruleTesterTs = new TypeScriptRuleTester();
-
-ruleTesterJs.run('"switch" statements should have "default" clauses [js]', rule, tests);
-ruleTesterTs.run('"switch" statements should have "default" clauses [ts]', rule, tests);
diff --git a/eslint-bridge/tests/linting/eslint/rules/todo-tag.test.ts b/eslint-bridge/tests/linting/eslint/rules/todo-tag.test.ts
deleted file mode 100644
index aaf4fd5636a..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/todo-tag.test.ts
+++ /dev/null
@@ -1,126 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/todo-tag';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
-ruleTester.run('Track uses of TODO tags', rule, {
- valid: [
- {
- code: `// Just a regular comment`,
- },
- {
- code: `
- // This is not aTODO comment
-
- // notatodo comment
-
- // a todolist
-
- // método
- `,
- },
- {
- code: '// todos',
- },
- {
- code: '// todos ',
- },
- ],
- invalid: [
- {
- code: `// TODO`,
- errors: [
- {
- message: 'Complete the task associated to this "TODO" comment.',
- line: 1,
- endLine: 1,
- column: 4,
- endColumn: 8,
- },
- ],
- },
-
- {
- code: `/*TODO Multiline comment
- TODO: another todo
- (this line is not highlighted)
- with three todo
- */`,
- errors: [
- {
- message: 'Complete the task associated to this "TODO" comment.',
- line: 1,
- endLine: 1,
- column: 3,
- endColumn: 7,
- },
- {
- message: 'Complete the task associated to this "TODO" comment.',
- line: 2,
- endLine: 2,
- column: 7,
- endColumn: 11,
- },
- {
- message: 'Complete the task associated to this "TODO" comment.',
- line: 4,
- endLine: 4,
- column: 18,
- endColumn: 22,
- },
- ],
- },
- {
- code: `// TODO TODO`,
- errors: 1,
- },
- {
- code: `
- // TODO just do it
-
- // Todo just do it
-
- //todo comment
-
- // This is a TODO just do it
-
- // todo: things to do
-
- // :TODO: things to do
-
- // valid end of line todo
-
- /*
- TODO Multiline comment
- */
-
- /*
- TODO Multiline comment
-
- with two todo
- */
-
- // valid end of file TODO
- `,
- errors: 11,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/too-many-break-or-continue-in-loop.test.ts b/eslint-bridge/tests/linting/eslint/rules/too-many-break-or-continue-in-loop.test.ts
deleted file mode 100644
index d6f5ae649f8..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/too-many-break-or-continue-in-loop.test.ts
+++ /dev/null
@@ -1,228 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { TypeScriptRuleTester } from '../../../tools';
-import { rule } from 'linting/eslint/rules/too-many-break-or-continue-in-loop';
-
-const ruleTesterJs = new RuleTester({ parserOptions: { ecmaVersion: 2018 } });
-const ruleTesterTs = new TypeScriptRuleTester();
-
-const testCases = {
- valid: [
- {
- code: `
- for (i = 0; i < 10; i++) {
- if (i % 3 == 0) {
- break;
- }
- }
- `,
- },
- {
- code: `
- for (i = 0; i < 10; i++) {
- switch (i) {
- case 0:
- break;
- default:
- break;
- }
- }
- `,
- },
- {
- code: `
- for (i = 0; i < 10; i++) {
- label1: if (i % 3 == 0) {
- break label1;
- }
- label2: if (i % 3 == 0) {
- break label2;
- }
- }
- `,
- },
- ],
- invalid: [
- {
- code: `
- for (i = 0; i < 10; i++) {
- if (i % 3 == 0) {
- break;
- }
- if (i % 3 == 0) {
- continue;
- }
- }
- `,
- errors: [
- {
- line: 2,
- endLine: 2,
- column: 13,
- endColumn: 16,
- message: JSON.stringify({
- message:
- 'Reduce the total number of "break" and "continue" statements in this loop to use one at most.',
- secondaryLocations: [
- {
- message: '"break" statement.',
- column: 16,
- line: 4,
- endColumn: 22,
- endLine: 4,
- },
- {
- message: '"continue" statement.',
- column: 16,
- line: 7,
- endColumn: 25,
- endLine: 7,
- },
- ],
- }),
- },
- ],
- },
- {
- code: `
- label: for (i = 0; i < 10; i++) {
- for (j = 0; j < 10; j++) {
- break label;
- }
- if (i % 3 == 0) {
- break;
- }
- }
- `,
- errors: 1,
- },
- {
- code: `
- label: for (i = 0; i < 10; i++) {
- for (j = 0; j < 10; j++) {
- continue label;
- }
- if (i % 3 == 0) {
- break;
- }
- }
- `,
- errors: 1,
- },
- {
- code: `
- label: for (i = 0; i < 10; i++) {
- switch (i) {
- case 0:
- break label;
- default:
- break label;
- }
- }
- `,
- errors: 1,
- },
- {
- code: `
- for (i = 0; i < 10; i++) {
- (function() {
- for (i = 0; i < 10; i++) {
- if (i % 3 == 0) {
- break;
- }
- if (i % 3 == 0) {
- break;
- }
- }
- })();
- if (i % 3 == 0) {
- break;
- }
- }
- `,
- errors: 1,
- },
- {
- code: `
- for (i = 0; i < 10; i++) {
- (function*() {
- for (i = 0; i < 10; i++) {
- if (i % 3 == 0) {
- break;
- }
- if (i % 3 == 0) {
- break;
- }
- }
- })();
- if (i % 3 == 0) {
- break;
- }
- }
- `,
- errors: 1,
- },
- {
- code: `
- for (i = 0; i < 10; i++) {
- if (i % 3 == 1) {
- break;
- }
- if (i % 3 == 2) {
- continue;
- }
- if (i % 3 == 0) {
- continue;
- }
- }
- `,
- errors: 1,
- },
- {
- code: `
- for (var property in obj) {
- if (foo()) continue;
- if (bar) continue;
- }
- `,
- errors: 1,
- },
- {
- code: `
- for (const elem of array) {
- if (foo()) continue;
- if (bar) continue;
- }
- `,
- errors: 1,
- },
- ],
-};
-ruleTesterJs.run(
- 'Loops should not contain more than a single "break" or "continue" statement JS',
- rule,
- testCases,
-);
-ruleTesterTs.run(
- 'Loops should not contain more than a single "break" or "continue" statement TS',
- rule,
- testCases,
-);
diff --git a/eslint-bridge/tests/linting/eslint/rules/unicode-aware-regex.test.ts b/eslint-bridge/tests/linting/eslint/rules/unicode-aware-regex.test.ts
deleted file mode 100644
index 7205d13583a..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/unicode-aware-regex.test.ts
+++ /dev/null
@@ -1,121 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/unicode-aware-regex';
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2018, sourceType: 'module' } });
-ruleTester.run(`Regular expressions using Unicode constructs with the 'u' flag`, rule, {
- valid: [
- {
- code: `/\\u{1234}/u`,
- },
- {
- code: `/\\u{12346}/u`,
- },
- {
- code: `/\\p{Alpha}/u`,
- },
- {
- code: `/\\p{Script=Latin}/u`,
- },
- {
- code: `/\\P{Alpha}/u`,
- },
- {
- code: `/[\\p{Alpha}]/u`,
- },
- {
- code: `/\\p/`,
- },
- {
- code: `/\\p{/`,
- },
- {
- code: `/\\p{a/`,
- },
- {
- code: `/\\p{a=/`,
- },
- {
- code: `/\\p{a=b/`,
- },
- {
- code: `/a+/u`,
- },
- {
- code: `/\\u{12}/`,
- },
- {
- code: `/\\u{12,34}/`,
- },
- ],
- invalid: [
- {
- code: `/\\u{1234}/`,
- errors: [
- {
- message: JSON.stringify({
- message: `Enable the 'u' flag for this regex using Unicode constructs.`,
- secondaryLocations: [
- { message: `Unicode character`, column: 1, line: 1, endColumn: 9, endLine: 1 },
- ],
- }),
- line: 1,
- endLine: 1,
- column: 1,
- endColumn: 11,
- },
- ],
- },
- {
- code: `/\\u{12346}/`,
- errors: 1,
- },
- {
- code: `/\\p{Alpha}/`,
- errors: [
- {
- message: JSON.stringify({
- message: `Enable the 'u' flag for this regex using Unicode constructs.`,
- secondaryLocations: [
- { message: `Unicode property`, column: 1, line: 1, endColumn: 11, endLine: 1 },
- ],
- }),
- line: 1,
- endLine: 1,
- column: 1,
- endColumn: 12,
- },
- ],
- },
- {
- code: `/\\P{Alpha}/`,
- errors: 1,
- },
- {
- code: `/\\P{Script=Latin}/`,
- errors: 1,
- },
- {
- code: `/[\\p{Alpha}]/`,
- errors: 1,
- },
- ],
-});
diff --git a/eslint-bridge/tests/linting/eslint/rules/unused-import.test.ts b/eslint-bridge/tests/linting/eslint/rules/unused-import.test.ts
deleted file mode 100644
index f4d2eba4188..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/unused-import.test.ts
+++ /dev/null
@@ -1,469 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { RuleTester } from 'eslint';
-import { rule } from 'linting/eslint/rules/unused-import';
-import path from 'path';
-import { BabelRuleTester } from '../../../tools';
-
-const babelRuleTester = BabelRuleTester();
-
-babelRuleTester.run('Unnecessary imports should be removed', rule, {
- valid: [
- {
- code: `
- import a from 'b';
- console.log(a);
- `,
- },
- {
- code: `
- import { a } from 'b';
- console.log(a);
- `,
- },
- {
- code: `
- import { a, b } from 'c';
- console.log(a);
- console.log(b);
- `,
- },
- {
- code: `
- import { a as b } from 'c';
- console.log(b);
- `,
- },
- {
- code: `import React from 'react';`,
- },
- {
- code: `
- import { a } from 'b';
-
- `,
- },
- {
- code: `
- import type { a } from 'b';
- function f(param: a) {}
- `,
- },
- {
- code: `
- /** @jsx jsx */
- import { jsx } from '@emotion/core'`,
- },
- {
- code: `
- /** @jsx jsx */
- import { jsx } from 'any'`,
- },
- ],
- invalid: [
- {
- code: `import a from 'b';`,
- errors: [
- {
- message: `Remove this unused import of 'a'.`,
- line: 1,
- endLine: 1,
- column: 8,
- endColumn: 9,
- suggestions: [
- {
- desc: `Remove this import statement`,
- output: ``,
- },
- ],
- },
- ],
- },
- {
- code: `import a, {b} from 'b'; console.log(b)`,
- errors: [
- {
- suggestions: [
- {
- desc: `Remove this variable import`,
- output: `import {b} from 'b'; console.log(b)`,
- },
- ],
- },
- ],
- },
- {
- code: `import a, {b} from 'b'; console.log(a)`,
- errors: [errorWithSuggestion(`import a from 'b'; console.log(a)`)],
- },
- {
- code: `import a, * as c from 'b'; console.log(a)`,
- errors: [errorWithSuggestion(`import a from 'b'; console.log(a)`)],
- },
- {
- code: `import { a } from 'b';`,
- errors: 1,
- },
- {
- code: `import { a, b, c } from 'c';`,
- errors: [
- errorWithSuggestion(`import { b, c } from 'c';`),
- errorWithSuggestion(`import { a, c } from 'c';`),
- errorWithSuggestion(`import { a, b } from 'c';`),
- ],
- },
- {
- code: `
- import { a, b } from 'c';
- console.log(b);
- `,
- errors: 1,
- },
- {
- code: `import * as a from 'b';`,
- errors: 1,
- },
- {
- code: `import { a as b, c } from 'c'; console.log(c);`,
- errors: [errorWithSuggestion(`import { c } from 'c'; console.log(c);`)],
- },
- {
- code: `import typeof a from 'b';`,
- errors: [errorWithSuggestion(``)],
- },
- {
- code: `import type { a, b } from 'b'; console.log(b);`,
- errors: [errorWithSuggestion(`import type { b } from 'b'; console.log(b);`)],
- },
- {
- code: `
-// comment
-import Foo from "foo";
-import bar from "bar";
-
-bar();`,
- errors: [
- errorWithSuggestion(`
-// comment
-import bar from "bar";
-
-bar();`),
- ],
- },
- {
- code: `import React, { Component } from 'react';`,
- errors: 1,
- },
- {
- code: `import { jsx } from '@emotion/core'`,
- errors: 1,
- },
- {
- code: `
- import { h } from 'some/lib'; // no 'h' jsxFactory
- export class Component {
- render() {
- return Hello, world!
- }
- }
- `,
- errors: 1,
- },
- ],
-});
-
-const ruleTesterTS = new RuleTester({
- parserOptions: { ecmaVersion: 2018, sourceType: 'module' },
- parser: require.resolve('@typescript-eslint/parser'),
-});
-
-ruleTesterTS.run('Unnecessary imports should be removed', rule, {
- valid: [
- {
- code: `
- import * as Foo from 'foobar';
- let k: Foo;
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Foo.Bar;
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Foo.Bar.Baz;
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Foo;
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Bar;
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Foo | Bar;
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Foo & Bar;
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- interface I extends Foo {}
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- interface I extends Foo.Bar {}
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- interface I extends Foo {}
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- class C implements Foo {}
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- class C implements Foo.Bar {}
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- class C implements Foo {}
- `,
- },
- {
- code: `
- import * as Foo from 'foobar';
- class C extends Foo {}
- `,
- },
- ],
- invalid: [
- {
- code: `import * as Foo from 'foobar';`,
- errors: 1,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Bar.Foo;
- `,
- errors: 1,
- },
- {
- code: `
- import * as Foo from 'foobar';
- let k: Baz.Bar.Foo;
- `,
- errors: 1,
- },
- {
- code: `
- import * as Foo from 'foobar';
- interface I extends Bar.Foo {};
- `,
- errors: 1,
- },
- {
- code: `
- import * as Foo from 'foobar';
- class C implements Bar.Foo {};
- `,
- errors: 1,
- },
- ],
-});
-
-const ruleTesterJsxFactory = new RuleTester({
- parserOptions: {
- ecmaVersion: 2018,
- sourceType: 'module',
- ecmaFeatures: { jsx: true },
- project: path.resolve(`${__dirname}/fixtures/unused-import/tsconfig.json`),
- },
- parser: require.resolve('@typescript-eslint/parser'),
-});
-
-const filename = path.resolve(`${__dirname}/fixtures/unused-import/file.tsx`);
-
-ruleTesterJsxFactory.run('Unused imports denoting jsx factory should be ignored', rule, {
- valid: [
- {
- filename,
- code: `
- import { h } from 'some/lib';
- export class Component {
- render() {
- return Hello, world!
- }
- }
- `,
- },
- {
- filename,
- code: `
- import { h } from 'some/lib';
- /* does something */
- `,
- },
- {
- filename,
- code: `
- import { Fragment } from 'some/lib';
- /* does something */
- `,
- },
- ],
- invalid: [
- {
- filename,
- code: `
- import { g } from 'some/lib';
- export class Component {
- render() {
- return Hello, world!
- }
- }
- `,
- errors: 1,
- },
- {
- filename,
- code: `
- import { g, h } from 'some/lib';
- export class Component {
- render() {
- return Hello, world!
- }
- }
- `,
- errors: [{ message: `Remove this unused import of 'g'.` }],
- },
- ],
-});
-
-const ruleTesterVue = new RuleTester({
- parserOptions: { ecmaVersion: 2018, sourceType: 'module' },
- parser: require.resolve('vue-eslint-parser'),
-});
-
-ruleTesterVue.run('Unnecessary imports should be removed', rule, {
- valid: [
- {
- code: `
-
-
-
-
- `,
- },
- {
- code: `
-
-
-
-
- `,
- },
- {
- code: `
-
-
-
-
- `,
- },
- {
- code: `
-
-
-
-
- `,
- },
- {
- code: `
-
-
-
-
- `,
- },
- ],
- invalid: [
- {
- code: `
-
-
-
-
- `,
- errors: 1,
- },
- ],
-});
-
-function errorWithSuggestion(output: string) {
- return {
- suggestions: [
- {
- output,
- },
- ],
- };
-}
diff --git a/eslint-bridge/tests/linting/eslint/rules/unused-named-groups.test.ts b/eslint-bridge/tests/linting/eslint/rules/unused-named-groups.test.ts
deleted file mode 100644
index a6fd197ff0c..00000000000
--- a/eslint-bridge/tests/linting/eslint/rules/unused-named-groups.test.ts
+++ /dev/null
@@ -1,585 +0,0 @@
-/*
- * SonarQube JavaScript Plugin
- * Copyright (C) 2011-2023 SonarSource SA
- * mailto:info AT sonarsource DOT com
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 3 of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public License
- * along with this program; if not, write to the Free Software Foundation,
- * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- */
-import { rule } from 'linting/eslint/rules/unused-named-groups';
-import { RuleTester } from 'eslint';
-import { JavaScriptRuleTester } from '../../../tools';
-
-const typeAwareRuleTester = new JavaScriptRuleTester();
-typeAwareRuleTester.run('Regular expressions named groups should be used', rule, {
- valid: [
- {
- code: `
- const pattern = /(?\\w)/;
- const matched = 'str'.matchAll(pattern);
- if (matched) {
- matched.groups.foo;
- }
- `,
- },
- {
- code: `
- const pattern = /(?\\w)/;
- const matched = 'str'.match(pattern);
- if (matched) {
- matched.groups.foo;
- }
- `,
- },
- {
- code: `
- const pattern = /(?\\w)(?\\w)(?\\w)/;
- const matched = 'str'.match(pattern);
- if (matched) {
- matched.groups.foo;
- matched.groups.bar;
- matched.groups.baz;
- }
- `,
- },
- {
- code: `
- const pattern = /(?\\w)/;
- const matched = pattern.exec('str');
- if (matched) {
- matched.indices.groups.foo;
- }
- `,
- },
- {
- code: `
- const pattern = 12345;
- const matched = 'str'.matchAll(pattern);
- if (matched) {
- matched.groups.foo;
- }
- `,
- },
- {
- code: `
- const matched = 'str'.matchAll(unknownPattern);
- if (matched) {
- matched.groups.foo;
- }
- `,
- },
- {
- code: `
- const matched = 'str'.matchAll(/(?\\w)/);
- if (matched) {
- matched.groups!.foo;
- }
- `,
- },
- {
- code: `
- function foo(unknownPattern) {
- const matched = 'str'.matchAll(unknownPattern);
- if (matched) {
- matched.groups.foo;
- }
- }
- `,
- },
- {
- code: `
- const pattern = /(?