forked from GoogleCloudPlatform/functions-framework-nodejs
-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Labels
priority: highHigh priority issueHigh priority issuetype: maintenanceMinor enhancement or refactoryMinor enhancement or refactory
Milestone
Description
Try to resolve this: #10 (comment)
One more thing, I think go ff's handling of function output and return error is more reasonable.
What if send fails? Here're more refs:
- automatically set http ret code based on function error code https://github.com/OpenFunction/functions-framework-go/blob/main/runtime/knative/knative.go#L66
- encapsule function output into context: OpenFunction/functions-framework-go@f1e311b/runtime/runtime.go#L134
- return error in function when send fails or other errors occur : https://github.com/OpenFunction/samples/blob/main/functions/knative/with-output-binding/sender.go#L23
benjaminhuo
Metadata
Metadata
Assignees
Labels
priority: highHigh priority issueHigh priority issuetype: maintenanceMinor enhancement or refactoryMinor enhancement or refactory