Add Sentry logs (#532)

itaybre · web-flow · commit 43b18fa08bbd · 2025-08-05T16:56:08.000-03:00
Added some example logs to the app <img width="560" height="241" alt="image" src="https://github.com/user-attachments/assets/410f37af-49bf-45d4-8135-d3e95b7bd169" />
diff --git a/ios/HackerNews.xcodeproj/project.pbxproj b/ios/HackerNews.xcodeproj/project.pbxproj
@@ -1216,7 +1216,7 @@
 			repositoryURL = "https://github.com/getsentry/sentry-cocoa/";
 			requirement = {
 				kind = upToNextMajorVersion;
-				minimumVersion = 8.50.1;
+				minimumVersion = 8.54.0;
 			};
 		};
 		A42271692DE78DEF002F03D5 /* XCRemoteSwiftPackageReference "faultordering" */ = {
diff --git a/ios/HackerNews.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/ios/HackerNews.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
diff --git a/ios/HackerNews/AppViewModel.swift b/ios/HackerNews/AppViewModel.swift
@@ -257,13 +257,13 @@ final class AppViewModel {
 
   func loginSubmit(username: String, password: String) async -> LoginStatus {
     let status = await webClient.login(acct: username, pw: password)
-    print("Login Status: \(status)")
+    Logger.info("Login Status: \(status)")
     switch status {
     case .success:
       showLoginSheet = false
       authState = .loggedIn
     case .error:
-      print("Login failed")
+      Logger.error("Login failed")
       authState = .loggedOut
     }
     return status
diff --git a/ios/HackerNews/Comments/CommentsViewModel.swift b/ios/HackerNews/Comments/CommentsViewModel.swift
@@ -135,7 +135,7 @@ class CommentsViewModel {
   }
 
   func fetchPage() async {
-    print("Fetching comments")
+    Logger.info("Fetching comments")
     state.comments = .loading
     let page = await webClient.getStoryPage(id: story.id)
     switch page {
@@ -158,7 +158,7 @@ class CommentsViewModel {
   func likePost(upvoted: Bool, url: String) async {
     switch state.auth {
     case .loggedIn:
-      print("Like Post: \(url)")
+      Logger.info("Like Post: \(url)")
       guard !url.isEmpty || upvoted else { return }
       state.headerState.upvoted = true
       await webClient.upvoteItem(upvoteUrl: url)
@@ -181,7 +181,7 @@ class CommentsViewModel {
           comment
         }
       })
-      print("Like Comment: \(data.upvoteUrl)")
+      Logger.info("Like Comment: \(data.upvoteUrl)")
       await webClient.upvoteItem(upvoteUrl: data.upvoteUrl)
     case .loggedOut:
       navigation(.login)
diff --git a/ios/HackerNews/HNApp.swift b/ios/HackerNews/HNApp.swift
@@ -40,6 +40,7 @@ struct HackerNewsApp: App {
       options.enableAppHangTrackingV2 = true
       options.sessionReplay.onErrorSampleRate = 1.0
       options.sendDefaultPii = true
+      options.experimental.enableLogs = true
       
 #if DEBUG
       options.environment = "development"
@@ -67,6 +68,7 @@ struct HackerNewsApp: App {
         options.environment = "xctest"
       }
     }
+    Logger.info("App launched")
   }
 
   var body: some Scene {
diff --git a/ios/HackerNews/Network/HNWebClient.swift b/ios/HackerNews/Network/HNWebClient.swift
@@ -102,7 +102,7 @@ class HNWebClient {
           commentForm: commentFormData
         ))
     } catch {
-      print("Error fetching post IDs: \(error)")
+      Logger.error("Error fetching post IDs: \(error)")
       return .error
     }
   }
@@ -162,6 +162,7 @@ class HNWebClient {
       let comments = try document.comments()
       return comments
     } catch {
+      Logger.error("Failed to post comment: \(error)")
       return []
     }
   }
diff --git a/ios/HackerNews/Settings/SendFeedbackScreen.swift b/ios/HackerNews/Settings/SendFeedbackScreen.swift
@@ -85,6 +85,7 @@ struct SendFeedbackScreen: View {
       source: .custom
     )
     SentrySDK.capture(feedback: feedback)
+    Logger.info("Feedback sent")
 
     withAnimation {
       isSubmitted = true
diff --git a/ios/HackerNews/Stories/StoryRow.swift b/ios/HackerNews/Stories/StoryRow.swift
@@ -34,7 +34,7 @@ struct StoryRow: View {
             } else {
               .storyComments(story: content.toStory())
             }
-          print("Navigating to \(destination)")
+          Logger.info("Navigating to \(destination)")
           model.navigationPath.append(destination)
         }
       } label: {
@@ -74,7 +74,7 @@ struct StoryRow: View {
             Spacer()
             // Comment Button
             Button(action: {
-              print("Pressed comment button for: \(content.id)")
+              Logger.info("Pressed comment button for: \(content.id)")
               model.navigationPath.append(
                 AppViewModel.AppNavigation.storyComments(
                   story: content.toStory())
diff --git a/ios/HackerNews/Utils/Logger.swift b/ios/HackerNews/Utils/Logger.swift
@@ -0,0 +1,13 @@
+import Sentry
+
+struct Logger {
+    static func info(_ message: String) {
+        print(message)
+        SentrySDK.logger.info(message)
+    }
+    
+    static func error(_ message: String) {
+        print(message)
+        SentrySDK.logger.error(message)
+    }
+}
diff --git a/ios/HackerNews/Utils/NetworkDebugInterceptor.swift b/ios/HackerNews/Utils/NetworkDebugInterceptor.swift
@@ -76,7 +76,7 @@ private final class DebugProtocol: URLProtocol {
     error: Error?,
     elapsed: Double
   ) {
-    let logger = Logger(
+    let logger = os.Logger(
       subsystem: Bundle.main.bundleIdentifier ?? "NetworkDebug",
       category: "🌐"
     )

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,7 @@ struct HackerNewsApp: App {`
`40`	`40`	`options.enableAppHangTrackingV2 = true`
`41`	`41`	`options.sessionReplay.onErrorSampleRate = 1.0`
`42`	`42`	`options.sendDefaultPii = true`
	`43`	`+ options.experimental.enableLogs = true`
`43`	`44`
`44`	`45`	`#if DEBUG`
`45`	`46`	`options.environment = "development"`
`@@ -67,6 +68,7 @@ struct HackerNewsApp: App {`
`67`	`68`	`options.environment = "xctest"`
`68`	`69`	`}`
`69`	`70`	`}`
	`71`	`+ Logger.info("App launched")`
`70`	`72`	`}`
`71`	`73`
`72`	`74`	`var body: some Scene {`
Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ class HNWebClient {`
`102`	`102`	`commentForm: commentFormData`
`103`	`103`	`))`
`104`	`104`	`} catch {`
`105`		`- print("Error fetching post IDs: \(error)")`
	`105`	`+ Logger.error("Error fetching post IDs: \(error)")`
`106`	`106`	`return .error`
`107`	`107`	`}`
`108`	`108`	`}`
`@@ -162,6 +162,7 @@ class HNWebClient {`
`162`	`162`	`let comments = try document.comments()`
`163`	`163`	`return comments`
`164`	`164`	`} catch {`
	`165`	`+ Logger.error("Failed to post comment: \(error)")`
`165`	`166`	`return []`
`166`	`167`	`}`
`167`	`168`	`}`
Original file line number	Diff line number	Diff line change
`@@ -85,6 +85,7 @@ struct SendFeedbackScreen: View {`
`85`	`85`	`source: .custom`
`86`	`86`	`)`
`87`	`87`	`SentrySDK.capture(feedback: feedback)`
	`88`	`+ Logger.info("Feedback sent")`
`88`	`89`
`89`	`90`	`withAnimation {`
`90`	`91`	`isSubmitted = true`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ private final class DebugProtocol: URLProtocol {`
`76`	`76`	`error: Error?,`
`77`	`77`	`elapsed: Double`
`78`	`78`	`) {`
`79`		`- let logger = Logger(`
	`79`	`+ let logger = os.Logger(`
`80`	`80`	`subsystem: Bundle.main.bundleIdentifier ?? "NetworkDebug",`
`81`	`81`	`category: "🌐"`
`82`	`82`	`)`