From 006ab8a93b2f350d30e9778bbbfe012bcc39d31f Mon Sep 17 00:00:00 2001 From: Ellet Date: Wed, 22 Jan 2025 18:34:04 +0300 Subject: [PATCH 1/5] ci: add the required permission for github-release job --- .github/workflows/publish.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 7a64a47..42d065a 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -9,12 +9,13 @@ jobs: name: Publish to pub.dev permissions: id-token: write # Required for authentication using OIDC to publish to pub.dev - contents: write # Required for creating a GitHub release and uploading the LICENSE file uses: dart-lang/setup-dart/.github/workflows/publish.yml@v1 github-release: name: Create GitHub Release needs: publish runs-on: ubuntu-latest + permissions: + contents: write # Required for creating a GitHub release and uploading the LICENSE file steps: - name: 📥 Checkout Repository From e3bf7caf733e32112864410ad8650e54e46b35b2 Mon Sep 17 00:00:00 2001 From: Ellet Date: Fri, 24 Jan 2025 01:58:48 -0800 Subject: [PATCH 2/5] ci: configure labeler to reflect swift and dart labels (#10) --- .github/labeler.yml | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 7390760..0a32796 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -18,5 +18,20 @@ test: - changed-files: - any-glob-to-all-files: - test/** - - example/macos/RunnerTests/**/*.swift - - example/macos/RunnerUITests/**/*.swift + - example/integration_test/** + - example/macos/RunnerTests/** + - example/macos/RunnerUITests/** + - example/test/** + +dart: + - changed-files: + - any-glob-to-all-files: + - lib/**/*.dart + - test/**/*.dart + - example/**/*.dart + +swift: + - changed-files: + - any-glob-to-all-files: + - macos/**/*.swift + - example/macos/**/*.swift From aadbde44e95cc5e98856dd8995e405a72f646395 Mon Sep 17 00:00:00 2001 From: Ellet Date: Fri, 24 Jan 2025 17:21:21 +0300 Subject: [PATCH 3/5] ci: set timeout in tests.yml --- .github/workflows/tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ff0c768..8f6cf04 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -10,6 +10,7 @@ jobs: dart-unit-tests: name: Dart unit tests runs-on: ubuntu-latest + timeout-minutes: 10 steps: - uses: actions/checkout@v4 @@ -29,6 +30,7 @@ jobs: native-macos-unit-tests: name: Native macOS unit tests runs-on: macos-latest + timeout-minutes: 15 steps: - uses: actions/checkout@v4 From 9fa11523c117bee020f5e5a223d7593cf1db004e Mon Sep 17 00:00:00 2001 From: Ellet Date: Sat, 25 Jan 2025 10:25:13 -0800 Subject: [PATCH 4/5] chore(readme): super nit --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 58b6f66..693a4aa 100644 --- a/README.md +++ b/README.md @@ -168,7 +168,7 @@ This functionality was originally proposed as a [pull request to `image_picker_m ## 🧪 Testing > [!TIP] -> With this approach, you can effectively test this platform implementation with the existing packages that use `image_picker` APIs. All platform-specific calls to `NativeImagePickerMacOS` should use the instance from `ImagePickerPlatform.interface` instead of creating a new `NativeImagePickerMacOS` to work. +> With this approach, you can effectively test this platform implementation with the existing packages that use `image_picker` APIs. All platform-specific calls to `NativeImagePickerMacOS` should use the instance from `ImagePickerPlatform.instance` instead of creating a new `NativeImagePickerMacOS` to work. To override the methods implementation for unit testing, add the dev dependencies: From 3eab7a7a225dc4cb48a556cdd5f5a9976187f646 Mon Sep 17 00:00:00 2001 From: Ellet Date: Thu, 19 Jun 2025 15:02:55 +0300 Subject: [PATCH 5/5] ci: avoid pub updates dependabot --- .github/dependabot.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 281b8a0..3f52d87 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -4,7 +4,8 @@ updates: directory: / schedule: interval: daily - - package-ecosystem: pub - directory: / - schedule: - interval: daily + # This creates too much PR noise; we prefer manual updates. + # - package-ecosystem: pub + # directory: / + # schedule: + # interval: daily