Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CommandAPI/CommandAPI
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: CommandAPI/CommandAPI
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev/rework-tests
Choose a head ref
  • 3 commits
  • 36 files changed
  • 1 contributor

Commits on Apr 13, 2025

  1. Rework and fix 1.20/1.20.1 tests 

    Ideas copied from 250dd67#diff-c3656d219e9578dc46011d4e6e4eee44ac06fef040f9b91e255a9718335ddf7e

Notably, using a Mockito spy now instead of overriding CommandAPIBukkit/NMS methods, and reworked the dependencies in the poms (which was likely the reason why the test were broken).

Spigot-mapped 1.20 is not working, and I still need to port these changes to the other test versions plus Kotlin.
    @willkroboth
    willkroboth committed Apr 13, 2025
    Configuration menu
    Copy the full SHA
    fd7861a View commit details
    Browse the repository at this point in the history

  2. Fix 1.20/1.20.1 spigot-mapped tests 

    I really hope there is an easy way to include different transitive dependencies based on the classifier
    @willkroboth
    willkroboth committed Apr 13, 2025
    Configuration menu
    Copy the full SHA
    0023e62 View commit details
    Browse the repository at this point in the history

  3. Update and fix 1.20.2 tests 

    Remove ParticleTests for dropped versions
Re-enable ArgumentItemStackTests and ignore failures in ArgumentItemStackPredicateTests (TODO: Fix item predicates in the tests)

The tests do reveal bugs once they work :P
- Fix bug in 1.20.2 NMS for `EntitySelectorArgument.ManyEntities`
- Fix NMS_CommonWithFunctions#convertFunction not working on 1.20.2 due to wrong Spigot mappings for CommandFunction#getEntries. (Note that 1.20 and 1.20.1 are the only ones that use NMS_CommonWithFunctions now. There's probably a lot of stuff that can be simplified with the nms-common module that we don't have the old versions.)
    @willkroboth
    willkroboth committed Apr 13, 2025
    Configuration menu
    Copy the full SHA
    cd81b10 View commit details
    Browse the repository at this point in the history
Loading