-
-
Notifications
You must be signed in to change notification settings - Fork 74
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: CommandAPI/CommandAPI
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: CommandAPI/CommandAPI
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev/paper/fix-GHActions
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 14 commits
- 411 files changed
- 2 contributors
Commits on Dec 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb56e00 - Browse repository at this point
Copy the full SHA eb56e00View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf27e55 - Browse repository at this point
Copy the full SHA bf27e55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 438e955 - Browse repository at this point
Copy the full SHA 438e955View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0a5583 - Browse repository at this point
Copy the full SHA f0a5583View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f06da7 - Browse repository at this point
Copy the full SHA 7f06da7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 297df88 - Browse repository at this point
Copy the full SHA 297df88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0079069 - Browse repository at this point
Copy the full SHA 0079069View commit details -
Configuration menu - View commit details
-
Copy full SHA for c67cc03 - Browse repository at this point
Copy the full SHA c67cc03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fc3dc2 - Browse repository at this point
Copy the full SHA 9fc3dc2View commit details -
Fix nms versions for spigot-1.21 and spigot-1.21.2
1.21 was patched by 1.21.1, and 1.21.2 was patched by 1.21.3, so the original NMS versions aren't available anymore. This was correctly updated in `commandapi-bukkit`, but not in `commandapi-spigot`. `commandapi-spigot` should now match `commandapi-bukkit`.
Configuration menu - View commit details
-
Copy full SHA for 4500fa0 - Browse repository at this point
Copy the full SHA 4500fa0View commit details -
Update usage of
ConfigurationAdapter
in VelocityOn `dev/dev`, `ConfigurationAdapter#saveDefaultConfig` could be used to save the default settings for a platform to a file. However, since Spigot and Paper have different config options, `DefaultBukkitConfig` was updated to handle both Paper and Spigot configs. Therefore, `BukkitConfigurationAdapter#saveDefaultConfig` did not have a single default config, so the signature of `saveDefaultConfig` was updated to input the instance of `DefaultConfig` that should be written to the file. This commit fixes a mistake where Velocity was still trying to use the `saveDefaultConfig` method with only two arguments. Since `saveDefaultConfig` no longer always uses *the* default config for the platform, I also renamed the method to `saveConfig`. Something to think about in code review: `DefaultBukkitConfig` is in `commandapi-bukkit`, but it contains the Paper-specific field `SHOULD_HOOK_PAPER_RELOAD`. This field does not need to exist on Spigot, so should it be moved into a Paper-specific subclass of `DefaultBukkitConfig`, similar to what happens with `CommandAPIBukkitConfig` and `CommandAPIPaperConfig`? Also, do we need 4 `CommandAPIMain` classes? Can we put them into a common module like before? Perhaps the command conversion logic can be extracted into the Bukkit module, and the config stuff can be extracted into a `spigot/paper-plugin-common`
Configuration menu - View commit details
-
Copy full SHA for a78062c - Browse repository at this point
Copy the full SHA a78062cView commit details -
Move tests into
dev.commandapi.test.tests
packageMakes it easier to distinguish test cases versus classes that help the tests work (e.g. `TestBase`, `MockCommandAPIServer`, etc.)
Configuration menu - View commit details
-
Copy full SHA for d5fc4ab - Browse repository at this point
Copy the full SHA d5fc4abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eddfce - Browse repository at this point
Copy the full SHA 5eddfceView commit details
Commits on Jan 4, 2025
-
Update 1.20 test implementations to match new Paper structure
Created Mock versions for classes that are meant to be implemented in Paper/Spigot. Select NMS method implementations are now overridden using a Mockito spy rather than manually reimplementing all methods and directing some to the original object. Made some changes and comments in non-test classes based on test results. TODO: - Make Paper/Spigot specific tests for chat arguments - Fix CustomArgument tests - Update test-impl for other versions
Configuration menu - View commit details
-
Copy full SHA for 250dd67 - Browse repository at this point
Copy the full SHA 250dd67View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...dev/paper/fix-GHActions