Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: CommandAPI/CommandAPI
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: CommandAPI/CommandAPI
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: dev/compare-nms-common-bytecode
Choose a head ref
  • 13 commits
  • 14 files changed
  • 2 contributors

Commits on Apr 17, 2025

  1. Clean up NMS_Common to make it compile for all supported versions

    @DerEchtePilz
    DerEchtePilz committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    b8436bd View commit details
    Browse the repository at this point in the history

  2. Use 1.21.3 dependency

    @DerEchtePilz
    DerEchtePilz committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    cc3981b View commit details
    Browse the repository at this point in the history

  3. Use more GH Actions steps to fail the build when it isn't compatible … 

    …with a version
    @DerEchtePilz
    DerEchtePilz committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    c9ae55d View commit details
    Browse the repository at this point in the history

  4. Use --quiet flag in the script

    @DerEchtePilz
    DerEchtePilz committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    227e5fa View commit details
    Browse the repository at this point in the history

  5. Remove unused method

    @DerEchtePilz
    DerEchtePilz committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    6db4696 View commit details
    Browse the repository at this point in the history

  6. Remove NMS_CommonWithFunctions_XXX classes

    @DerEchtePilz
    DerEchtePilz committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    90ce2e0 View commit details
    Browse the repository at this point in the history

  7. Make sure specialsource uses the correct version

    @DerEchtePilz
    DerEchtePilz committed Apr 17, 2025
    Configuration menu
    Copy the full SHA
    3bdcce4 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2025

  1. Move methods out and into NMS_Common when possible

    @DerEchtePilz
    DerEchtePilz committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    d4dabf3 View commit details
    Browse the repository at this point in the history

  2. Make compileNMSCommon.sh more compact

    @DerEchtePilz
    DerEchtePilz committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    84b2461 View commit details
    Browse the repository at this point in the history

  3. There's no need to have this static

    @DerEchtePilz
    DerEchtePilz committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    43e2929 View commit details
    Browse the repository at this point in the history

  4. Test comparing NMS_Common bytecode 

    Expand compileNMSCommon.sh script to generate diffs for the bytecode
I want to see if `exit 1` in the script makes the GitHub Actions build fail
    @willkroboth
    willkroboth committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    47e9b66 View commit details
    Browse the repository at this point in the history

  5. Fix indentation and maybe make script runnable by GH Actions

    @willkroboth
    willkroboth committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    2144b71 View commit details
    Browse the repository at this point in the history

  6. Actually make script runnable by GH Actions?

    @willkroboth
    willkroboth committed Apr 18, 2025
    Configuration menu
    Copy the full SHA
    2c12daa View commit details
    Browse the repository at this point in the history
Loading